Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2365573002: [build] Fix race in v8gen (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix race in v8gen BUG=chromium:648583 NOTRY=true Committed: https://crrev.com/6cd5d73c6c790a59f9e6a78a9c83b7db83ba4dec Cr-Commit-Position: refs/heads/master@{#39626}

Patch Set 1 #

Patch Set 2 : [build] Fix race in v8gen #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/dev/v8gen.py View 1 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2365573002/diff/20001/tools/dev/v8gen.py File tools/dev/v8gen.py (right): https://codereview.chromium.org/2365573002/diff/20001/tools/dev/v8gen.py#newcode271 tools/dev/v8gen.py:271: mtime = os.path.getmtime(gn_args_path) + 1 Really needs + ...
4 years, 2 months ago (2016-09-22 09:08:28 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-22 13:22:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365573002/20001
4 years, 2 months ago (2016-09-22 13:29:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-22 13:31:33 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 13:31:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cd5d73c6c790a59f9e6a78a9c83b7db83ba4dec
Cr-Commit-Position: refs/heads/master@{#39626}

Powered by Google App Engine
This is Rietveld 408576698