Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dev/v8gen.py

Issue 2365573002: [build] Fix race in v8gen (Closed)
Patch Set: [build] Fix race in v8gen Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dev/v8gen.py
diff --git a/tools/dev/v8gen.py b/tools/dev/v8gen.py
index 69db399d191319575bcd3fe1866d8e29fd5e0a0b..f0fb74b7094608373c94beb88b0f48f0c9d5c995 100755
--- a/tools/dev/v8gen.py
+++ b/tools/dev/v8gen.py
@@ -265,6 +265,13 @@ class GenerateGnArgs(object):
f.write('\n# Additional %s args:\n' % type)
f.write(more_gn_args)
f.write('\n')
+
+ # Artificially increment modification time as our modifications happen too
+ # fast. This makes sure that gn is properly rebuilding the ninja files.
+ mtime = os.path.getmtime(gn_args_path) + 1
Michael Achenbach 2016/09/22 09:08:28 Really needs + 1, smaller increments don't trigger
+ with open(gn_args_path, 'aw'):
+ os.utime(gn_args_path, (mtime, mtime))
+
return True
def main(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698