Component updater: report the Windows OS and Service Pack separately.

Component updater: report the Windows OS and Service Pack separately.

The current implementation of base::SysInfo().OperatingSystemVersion()
for Windows joins the version of the OS with some representation of
the Service Pack. That created a server configuration issue in the past
where a rule had been written assuming a dotted version string for the OS.
Since then, the authors of configuration files have learned to write rules
that consider the possibility that OS versions may not be dotted strings.

Traditionally, Omaha expected the OS version and Service Pack as serparate
entities in the Omaha protocol.

Other platforms but Windows and Linux use dotted version strings currently.
They have no Service Packs.

The Linux does not provide an implementation for
base::SysInfo::OperatingSystemVersionNumbers(). Linux versions could include
relevant information that does not fit the typical dotted string version.

In conclusion, this change is a minor improvement for the Windows OS metadata
and leaves the rest, including Linux, the same as before.

BUG=642476
Committed: https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484
Cr-Commit-Position: refs/heads/master@{#421296}

[Sorin Jianu, 2016-09-23 20:54:24]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[Sorin Jianu, 2016-09-23 20:54:33]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:54:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:51:24]

Dry run: This issue passed the CQ dry run.

[waffles, 2016-09-26 19:55:51]

lgtm

[Sorin Jianu, 2016-09-27 16:54:54]

sorin@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sorin Jianu, 2016-09-27 16:54:55]

scottmg@ please, I need an owner's review for the paths under base/win.

[scottmg, 2016-09-27 17:50:45]

base/win l-g-t-m, but as far as the usage, did you consider using a build number
instead of a service pack string?

Crashpad does this
https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/snapshot/w...
based on retrieving from kernel32.dll, but it's in OSVERSIONINFO[EX] too.

Alternatively, switching to OSVERSIONINFOEX and using wServicePackMajor/Minor?
https://msdn.microsoft.com/en-us/library/windows/desktop/ms724833(v=vs.85).aspx

Basically, not sure about having a raw string there that's not orderable, not
too parseable, etc.

[Sorin Jianu, 2016-09-27 17:56:54]

On 2016/09/27 17:50:45, scottmg wrote:
> base/win l-g-t-m, but as far as the usage, did you consider using a build
number
> instead of a service pack string?
> 
> Crashpad does this
>
https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/snapshot/w...
> based on retrieving from kernel32.dll, but it's in OSVERSIONINFO[EX] too.
> 
> Alternatively, switching to OSVERSIONINFOEX and using wServicePackMajor/Minor?
>
https://msdn.microsoft.com/en-us/library/windows/desktop/ms724833(v=vs.85).aspx
> 
> Basically, not sure about having a raw string there that's not orderable, not
> too parseable, etc.

Thank you Scott. 
We do this for compatibility with the existing Omaha, that's how the Omaha
backend handles the service pack.

[scottmg, 2016-09-27 18:20:34]

ok, lgtm then.

[Sorin Jianu, 2016-09-27 18:20:53]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:21:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:34:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 19:36:01]

Description was changed from

==========
Component updater: report the Windows OS and Service Pack separately.

The current implementation of base::SysInfo().OperatingSystemVersion()
for Windows joins the version of the OS with some representation of
the Service Pack. That created a server configuration issue in the past
where a rule had been written assuming a dotted version string for the OS.
Since then, the authors of configuration files have learned to write rules
that consider the possibility that OS versions may not be dotted strings.

Traditionally, Omaha expected the OS version and Service Pack as serparate
entities in the Omaha protocol.

Other platforms but Windows and Linux use dotted version strings currently.
They have no Service Packs.

The Linux does not provide an implementation for
base::SysInfo::OperatingSystemVersionNumbers(). Linux versions could include
relevant information that does not fit the typical dotted string version.

In conclusion, this change is a minor improvement for the Windows OS metadata
and leaves the rest, including Linux, the same as before.

BUG=642476
==========

to

==========
Component updater: report the Windows OS and Service Pack separately.

The current implementation of base::SysInfo().OperatingSystemVersion()
for Windows joins the version of the OS with some representation of
the Service Pack. That created a server configuration issue in the past
where a rule had been written assuming a dotted version string for the OS.
Since then, the authors of configuration files have learned to write rules
that consider the possibility that OS versions may not be dotted strings.

Traditionally, Omaha expected the OS version and Service Pack as serparate
entities in the Omaha protocol.

Other platforms but Windows and Linux use dotted version strings currently.
They have no Service Packs.

The Linux does not provide an implementation for
base::SysInfo::OperatingSystemVersionNumbers(). Linux versions could include
relevant information that does not fit the typical dotted string version.

In conclusion, this change is a minor improvement for the Windows OS metadata
and leaves the rest, including Linux, the same as before.

BUG=642476

Committed: https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484
Cr-Commit-Position: refs/heads/master@{#421296}
==========

[commit-bot: I haz the power, 2016-09-27 19:36:02]

Patchset 1 (id:??) landed as
https://crrev.com/435a1b4f0d12145d7f34c7645bb4e8bfb946f484
Cr-Commit-Position: refs/heads/master@{#421296}