Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: base/win/windows_version.h

Issue 2365523004: Component updater: report the Windows OS and Service Pack separately. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win/windows_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/windows_version.h
diff --git a/base/win/windows_version.h b/base/win/windows_version.h
index 7bc8b6fe560f5099ea6dec51b811d86d5b01eb4c..6eaf2df4516ef2174d09a10af3ec7db370e15d78 100644
--- a/base/win/windows_version.h
+++ b/base/win/windows_version.h
@@ -94,6 +94,7 @@ class BASE_EXPORT OSInfo {
VersionNumber version_number() const { return version_number_; }
VersionType version_type() const { return version_type_; }
ServicePack service_pack() const { return service_pack_; }
+ std::string service_pack_str() const { return service_pack_str_; }
WindowsArchitecture architecture() const { return architecture_; }
int processors() const { return processors_; }
size_t allocation_granularity() const { return allocation_granularity_; }
@@ -114,6 +115,11 @@ class BASE_EXPORT OSInfo {
VersionNumber version_number_;
VersionType version_type_;
ServicePack service_pack_;
+
+ // A string, such as "Service Pack 3", that indicates the latest Service Pack
+ // installed on the system. If no Service Pack has been installed, the string
+ // is empty.
+ std::string service_pack_str_;
WindowsArchitecture architecture_;
int processors_;
size_t allocation_granularity_;
« no previous file with comments | « no previous file | base/win/windows_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698