Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called

Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called
>
> This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the context gets destroyed.
>
> The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
> I think the risk is low.
>
> BUG=610176
>
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176, 649272
NOTRY=true

Committed: https://crrev.com/04b1826356a37de2a322e7e6e0e80f07d05f210f
Cr-Commit-Position: refs/heads/master@{#420498}

[dcheng, 2016-09-22 18:46:29]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-09-22 18:46:30]

Created Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called

[commit-bot: I haz the power, 2016-09-22 18:47:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-09-22 19:58:39]

Description was changed from

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176
==========

to

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
==========

[commit-bot: I haz the power, 2016-09-22 22:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:49:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dcheng, 2016-09-22 23:01:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-09-22 23:13:06]

webkit test failure seem like a flake e.g. I see same tests failing on other
unrelated CLs:

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

this is for https://codereview.chromium.org/2361493003 which is different code
from this revert.

Given this is a revert for a top crasher that is currently blocking a Dev
release, I'd like to manually land this.

[Will Harris, 2016-09-22 23:17:53]

Description was changed from

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
==========

to

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true
==========

[Will Harris, 2016-09-22 23:18:11]

spoke to dcheng and there is consensus this should be safe to land, so landing.

[Will Harris, 2016-09-22 23:18:16]

The CQ bit was unchecked by wfh@chromium.org

[Will Harris, 2016-09-22 23:18:28]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:19:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:24:45]

Description was changed from

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true
==========

to

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-22 23:24:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 23:28:30]

Description was changed from

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
> 
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
> 
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
> 
> BUG=610176
> 
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true
==========

to

==========
Revert of Clear LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of
https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed
gets called
>
> This CL clears LifecycleObserver::m_context when
LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the
context gets destroyed.
>
> The new behavior makes a lot of more sense, but the problem is that some
existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the
context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not
sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming
that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it
may cause a null-deref crash).
> I think the risk is low.
>
> BUG=610176
>
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true

Committed: https://crrev.com/04b1826356a37de2a322e7e6e0e80f07d05f210f
Cr-Commit-Position: refs/heads/master@{#420498}
==========

[commit-bot: I haz the power, 2016-09-22 23:28:31]

Patchset 1 (id:??) landed as
https://crrev.com/04b1826356a37de2a322e7e6e0e80f07d05f210f
Cr-Commit-Position: refs/heads/master@{#420498}

[haraken, 2016-09-22 23:33:28]

LGTM to revert

[haraken, 2016-09-23 12:09:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2367753002/ by haraken@chromium.org.

The reason for reverting is: Relanding this CL because the fix to the original
crash has been landed in https://codereview.chromium.org/2364693005/
.