Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2361493003:
Make toDataURL robust with respect to allocation failures (Closed)
|
Created:
4 years, 3 months ago by Justin Novosad Modified:
4 years, 3 months ago Reviewers:
xlai (Olivia) CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake toDataURL robust with respect to allocation failures
It is not safe to assume that ImageData::create always returns
a valid point. Internally it uses DOMUint8ClampedArray::createOrNull
which returns null instead of crashing when allocation fails.
This change adds the appropriate null pointer checks to take
that into account.
BUG=647824
NOTRY=true
Committed: https://crrev.com/7049607698f748d6c8f6024557fe2a9c4362ec2e
Cr-Commit-Position: refs/heads/master@{#420625}
Patch Set 1 #
Total comments: 1
Patch Set 2 : drive-by fix for toBlob #Messages
Total messages: 28 (16 generated)
The CQ bit was checked by junov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
junov@chromium.org changed reviewers: + xlai@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2361493003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/2361493003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:749: ImageData* imageData = toImageData(BackBuffer, SnapshotReasonToBlob); toBlob is also calling toImageData(). Could you write the failure response in toBlob as well?
The CQ bit was checked by junov@chromium.org to run a CQ dry run
New patch
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by junov@chromium.org
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 ========== to ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 NOTRY=true ==========
Commit blocked by unrelated flake. Using NOTRY...
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 NOTRY=true ========== to ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 NOTRY=true ========== to ========== Make toDataURL robust with respect to allocation failures It is not safe to assume that ImageData::create always returns a valid point. Internally it uses DOMUint8ClampedArray::createOrNull which returns null instead of crashing when allocation fails. This change adds the appropriate null pointer checks to take that into account. BUG=647824 NOTRY=true Committed: https://crrev.com/7049607698f748d6c8f6024557fe2a9c4362ec2e Cr-Commit-Position: refs/heads/master@{#420625} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7049607698f748d6c8f6024557fe2a9c4362ec2e Cr-Commit-Position: refs/heads/master@{#420625} |
