Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 23654045: ui: Fix removing a number from the SequentialIDGenerator. (Closed)

Created:
7 years, 3 months ago by sadrul
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

ui: Fix removing a number from the SequentialIDGenerator. Make sure when a number is released, the |min_available_slot_| is updated accordingly, so that subsequent allocations are set correctly to the lowest available ID. BUG=292929 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223517

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M ui/base/sequential_id_generator.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/base/sequential_id_generator.cc View 1 2 3 chunks +12 lines, -6 lines 0 comments Download
M ui/base/sequential_id_generator_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
https://codereview.chromium.org/23654045/diff/1/ui/base/sequential_id_generator.cc File ui/base/sequential_id_generator.cc (right): https://codereview.chromium.org/23654045/diff/1/ui/base/sequential_id_generator.cc#newcode63 ui/base/sequential_id_generator.cc:63: uint32 id = number_to_id_[number]; Should I just call ReleaseGeneratedID(number_to_id_[number]); ...
7 years, 3 months ago (2013-09-16 22:07:21 UTC) #1
sky
LGTM https://codereview.chromium.org/23654045/diff/5001/ui/base/sequential_id_generator.cc File ui/base/sequential_id_generator.cc (right): https://codereview.chromium.org/23654045/diff/5001/ui/base/sequential_id_generator.cc#newcode64 ui/base/sequential_id_generator.cc:64: if (id < min_available_id_) { Refactor 54-57 and ...
7 years, 3 months ago (2013-09-16 23:49:26 UTC) #2
sadrul
https://codereview.chromium.org/23654045/diff/5001/ui/base/sequential_id_generator.cc File ui/base/sequential_id_generator.cc (right): https://codereview.chromium.org/23654045/diff/5001/ui/base/sequential_id_generator.cc#newcode64 ui/base/sequential_id_generator.cc:64: if (id < min_available_id_) { On 2013/09/16 23:49:27, sky ...
7 years, 3 months ago (2013-09-17 02:26:38 UTC) #3
sadrul
7 years, 3 months ago (2013-09-17 02:27:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r223517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698