ui: Fix removing a number from the SequentialIDGenerator.

ui/base/sequential_id_generator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/sequential_id_generator.h"
 
 #include "base/logging.h"
 
 namespace {
 
@@ skipping 41 matching lines @@
 
 void SequentialIDGenerator::ReleaseGeneratedID(uint32 id) {
   if (id < min_available_id_) {
     min_available_id_ = id;
     DCHECK_GE(min_available_id_, min_id_);
   }
   Remove(id, &id_to_number_, &number_to_id_);
 }
 
 void SequentialIDGenerator::ReleaseNumber(uint32 number) {
+  DCHECK_GT(number_to_id_.count(number), 0U);
+  uint32 id = number_to_id_[number];
+  if (id < min_available_id_) {

[sky, 2013/09/16 23:49:27]

Refactor 54-57 and 64-67 to a common method?

[sadrul, 2013/09/17 02:26:38]

Done.

+    min_available_id_ = id;
+    DCHECK_GE(min_available_id_, min_id_);
+  }
   Remove(number, &number_to_id_, &id_to_number_);
 }
 
 uint32 SequentialIDGenerator::GetNextAvailableSlot() {
   const uint32 kMaxID = 128;
   while (id_to_number_.count(min_available_id_) > 0 &&
          min_available_id_ < kMaxID) {
     ++min_available_id_;
   }
   if (min_available_id_ >= kMaxID)
     min_available_id_ = min_id_;
   return min_available_id_;
 }
 
 }  // namespace ui