Chromium Code Reviews

Issue 23653059: Mark when effects and programs have vertex code (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Mark when effects and programs have vertex code Adds a 'hasVertexCode' method to GrEffect and a 'fHasVertexCode' field to GrGLProgramDesc::KeyHeader. Also adds a GrVertexEffect class that effects have to inherit from in order to set the 'hasVertexCode' flag and be able to emit vertex code, and updates the existing effects to use it as needed. Committed: http://code.google.com/p/skia/source/detail?r=11537

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+107 lines, -50 lines)
M include/gpu/GrEffect.h View 4 chunks +20 lines, -13 lines 0 comments
M src/gpu/GrAAConvexPathRenderer.cpp View 3 chunks +4 lines, -2 lines 0 comments
M src/gpu/GrAARectRenderer.cpp View 7 chunks +7 lines, -6 lines 0 comments
M src/gpu/GrEffect.cpp View 1 chunk +0 lines, -5 lines 0 comments
M src/gpu/GrOvalRenderer.cpp View 10 chunks +11 lines, -9 lines 0 comments
M src/gpu/effects/GrBezierEffect.h View 7 chunks +8 lines, -7 lines 0 comments
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 3 chunks +3 lines, -2 lines 0 comments
A src/gpu/effects/GrVertexEffect.h View 1 chunk +37 lines, -0 lines 0 comments
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +1 line, -0 lines 0 comments
M src/gpu/gl/GrGLProgramDesc.cpp View 5 chunks +13 lines, -3 lines 0 comments

Messages

Total messages: 4 (0 generated)
Chris Dalton
7 years, 3 months ago (2013-09-23 01:53:26 UTC) #1
bsalomon
lgtm
7 years, 3 months ago (2013-09-23 15:17:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23653059/1
7 years, 2 months ago (2013-09-30 19:24:33 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 19:55:57 UTC) #4
Message was sent while issue was closed.
Change committed as 11537

Powered by Google App Engine