Issue 23653059: Mark when effects and programs have vertex code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23653059: Mark when effects and programs have vertex code (Closed)

Created:
7 years, 3 months ago by Chris Dalton

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Mark when effects and programs have vertex code Adds a 'hasVertexCode' method to GrEffect and a 'fHasVertexCode' field to GrGLProgramDesc::KeyHeader. Also adds a GrVertexEffect class that effects have to inherit from in order to set the 'hasVertexCode' flag and be able to emit vertex code, and updates the existing effects to use it as needed. Committed: http://code.google.com/p/skia/source/detail?r=11537

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -50 lines)			Patch
M	include/gpu/GrEffect.h	View	4 chunks	+20 lines, -13 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	7 chunks	+7 lines, -6 lines	0 comments	Download
M	src/gpu/GrEffect.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/gpu/GrOvalRenderer.cpp	View	10 chunks	+11 lines, -9 lines	0 comments	Download
M	src/gpu/effects/GrBezierEffect.h	View	7 chunks	+8 lines, -7 lines	0 comments	Download
M	src/gpu/effects/GrBezierEffect.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrCustomCoordsTextureEffect.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
A	src/gpu/effects/GrVertexEffect.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View	5 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23653059/1

7 years, 2 months ago (2013-09-30 19:24:33 UTC) #3

Message was sent while issue was closed.

Change committed as 11537

Expand Messages | Collapse Messages