third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h - Issue 2365083002: Make NGFragment to own NGPhysicalFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h ('K') | « third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

index 5495c46d0f4e0113e515ebde657e2cd233bf9660..7e0e0e37d3b4e9583522fbc3d9ab467eb4405e02 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

@@ -21,13 +21,8 @@ class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragmentBase {

String Text() const { return text_list_->Text(start_offset_, end_offset_); }

- DEFINE_INLINE_TRACE_AFTER_DISPATCH() {

- visitor->trace(text_list_);

- NGPhysicalFragmentBase::traceAfterDispatch(visitor);

- }

private:

- Member<NGLayoutInputText> text_list_;

+ std::unique_ptr<NGLayoutInputText> text_list_;

unsigned start_offset_;

unsigned end_offset_;

};