Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
index 00d9ac99b60090e0c75d065e9b91e82bac5d5e8a..88e215e8f6c8c701cfddf356c8a011e21e6851d8 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
@@ -52,9 +52,9 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesNoExclusions) {
NGPhysicalSize physical_size;
physical_size.width = LayoutUnit(600);
physical_size.height = LayoutUnit(400);
- auto* physical_space = new NGPhysicalConstraintSpace(physical_size);
+ NGPhysicalConstraintSpace physical_space(physical_size);
auto* space =
- new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
+ new NGConstraintSpace(HorizontalTopBottom, LeftToRight, &physical_space);
bool for_inline_or_bfc = true;
auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
@@ -67,14 +67,14 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopRightExclusion) {
NGPhysicalSize physical_size;
physical_size.width = LayoutUnit(600);
physical_size.height = LayoutUnit(400);
- auto* physical_space = new NGPhysicalConstraintSpace(physical_size);
+ NGPhysicalConstraintSpace physical_space(physical_size);
// Add a 100x100 exclusion in the top right corner.
- physical_space->AddExclusion(NGExclusion(LayoutUnit(0), LayoutUnit(600),
- LayoutUnit(100), LayoutUnit(500)));
+ physical_space.AddExclusion(NGExclusion(LayoutUnit(0), LayoutUnit(600),
+ LayoutUnit(100), LayoutUnit(500)));
auto* space =
- new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
+ new NGConstraintSpace(HorizontalTopBottom, LeftToRight, &physical_space);
bool for_inline_or_bfc = true;
auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
@@ -92,14 +92,14 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopLeftExclusion) {
NGPhysicalSize physical_size;
physical_size.width = LayoutUnit(600);
physical_size.height = LayoutUnit(400);
- auto* physical_space = new NGPhysicalConstraintSpace(physical_size);
+ NGPhysicalConstraintSpace physical_space(physical_size);
// Add a 100x100 exclusion in the top left corner.
- physical_space->AddExclusion(NGExclusion(LayoutUnit(0), LayoutUnit(100),
- LayoutUnit(100), LayoutUnit(0)));
+ physical_space.AddExclusion(NGExclusion(LayoutUnit(0), LayoutUnit(100),
+ LayoutUnit(100), LayoutUnit(0)));
auto* space =
- new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
+ new NGConstraintSpace(HorizontalTopBottom, LeftToRight, &physical_space);
bool for_inline_or_bfc = true;
auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
@@ -127,17 +127,17 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTwoInMiddle) {
NGPhysicalSize physical_size;
physical_size.width = LayoutUnit(600);
physical_size.height = LayoutUnit(400);
- auto* physical_space = new NGPhysicalConstraintSpace(physical_size);
+ NGPhysicalConstraintSpace physical_space(physical_size);
// Add a 200x100 exclusion at 150x200
- physical_space->AddExclusion(NGExclusion(LayoutUnit(200), LayoutUnit(250),
- LayoutUnit(300), LayoutUnit(150)));
+ physical_space.AddExclusion(NGExclusion(LayoutUnit(200), LayoutUnit(250),
+ LayoutUnit(300), LayoutUnit(150)));
// Add a 50x50 exclusion at 500x350
- physical_space->AddExclusion(NGExclusion(LayoutUnit(350), LayoutUnit(550),
- LayoutUnit(400), LayoutUnit(500)));
+ physical_space.AddExclusion(NGExclusion(LayoutUnit(350), LayoutUnit(550),
+ LayoutUnit(400), LayoutUnit(500)));
auto* space =
- new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
+ new NGConstraintSpace(HorizontalTopBottom, LeftToRight, &physical_space);
bool for_inline_or_bfc = true;
auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);

Powered by Google App Engine
This is Rietveld 408576698