Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates.

Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they changed.

BUG=648775
Committed: https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477
Cr-Commit-Position: refs/heads/master@{#421264}

[dgozman, 2016-09-23 21:01:06]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2016-09-23 21:01:21]

Description was changed from

==========
Pass full ServiceWorkerVersionInfo in ServiceWorkerContextWatcher.

BUG=648775
==========

to

==========
Pass full ServiceWorkerVersionInfo in ServiceWorkerContextWatcher.

Otherwise some bits of information are missing.

BUG=648775
==========

[commit-bot: I haz the power, 2016-09-23 21:02:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-09-23 23:09:21]

Description was changed from

==========
Pass full ServiceWorkerVersionInfo in ServiceWorkerContextWatcher.

Otherwise some bits of information are missing.

BUG=648775
==========

to

==========
Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and
their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they
changed.

BUG=648775
==========

[dgozman, 2016-09-23 23:09:25]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 23:10:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-09-23 23:46:03]

dgozman@chromium.org changed reviewers:
+ horo@chromium.org

[dgozman, 2016-09-23 23:46:04]

Could you please take a look?

This adds live updates for ServiceWorkerVersion so that we can get
ServiceWorkerDevToolsAgentHost for it. It's used in this patch:
https://codereview.chromium.org/2354973003/.

Thanks,
Dmitry

[commit-bot: I haz the power, 2016-09-23 23:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:51:37]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[horo, 2016-09-26 01:30:06]

We use the route ID only for DevTools.
So we should have "DevTools" in the method names.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_core.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_core.cc:756: FROM_HERE,
&ServiceWorkerContextObserver::OnVersionRoutingIdsChanged,
OnVersionDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_core.h:130: void
OnRoutingIdsChanged(ServiceWorkerVersion* version) override;
OnDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_observer.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_observer.h:60: virtual
void OnVersionRoutingIdsChanged(int64_t version_id,
OnVersionDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.cc:210: void
ServiceWorkerContextWatcher::OnVersionRoutingIdsChanged(
OnVersionDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.h:78: void
OnVersionRoutingIdsChanged(int64_t version_id,
OnVersionDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:872:
FOR_EACH_OBSERVER(Listener, listeners_, OnRoutingIdsChanged(this));
OnDevToolsRoutingIdChanged

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.h:105: virtual void
OnRoutingIdsChanged(ServiceWorkerVersion* version) {}
OnDevToolsRoutingIdChanged

[dgozman, 2016-09-26 15:49:00]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2016-09-26 15:49:12]

PTAL, renamed all the things!

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_core.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_core.cc:756: FROM_HERE,
&ServiceWorkerContextObserver::OnVersionRoutingIdsChanged,
On 2016/09/26 01:30:05, horo wrote:
> OnVersionDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_core.h:130: void
OnRoutingIdsChanged(ServiceWorkerVersion* version) override;
On 2016/09/26 01:30:05, horo wrote:
> OnDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_observer.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_observer.h:60: virtual
void OnVersionRoutingIdsChanged(int64_t version_id,
On 2016/09/26 01:30:05, horo wrote:
> OnVersionDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.cc:210: void
ServiceWorkerContextWatcher::OnVersionRoutingIdsChanged(
On 2016/09/26 01:30:05, horo wrote:
> OnVersionDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.h:78: void
OnVersionRoutingIdsChanged(int64_t version_id,
On 2016/09/26 01:30:05, horo wrote:
> OnVersionDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.cc:872:
FOR_EACH_OBSERVER(Listener, listeners_, OnRoutingIdsChanged(this));
On 2016/09/26 01:30:05, horo wrote:
> OnDevToolsRoutingIdChanged

Done.

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/2365053002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_version.h:105: virtual void
OnRoutingIdsChanged(ServiceWorkerVersion* version) {}
On 2016/09/26 01:30:05, horo wrote:
> OnDevToolsRoutingIdChanged

Done.

[commit-bot: I haz the power, 2016-09-26 15:49:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:12:42]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[horo, 2016-09-26 22:29:52]

lgtm

[dgozman, 2016-09-27 03:25:40]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-27 03:26:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:04:14]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-09-27 15:15:41]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:16:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:06:52]

Description was changed from

==========
Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and
their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they
changed.

BUG=648775
==========

to

==========
Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and
their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they
changed.

BUG=648775
==========

[commit-bot: I haz the power, 2016-09-27 18:06:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 18:09:46]

Description was changed from

==========
Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and
their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they
changed.

BUG=648775
==========

to

==========
Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and
their updates.

We lacked these ids in OnNewLiveVersion and there were no updates when they
changed.

BUG=648775

Committed: https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477
Cr-Commit-Position: refs/heads/master@{#421264}
==========

[commit-bot: I haz the power, 2016-09-27 18:09:47]

Patchset 3 (id:??) landed as
https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477
Cr-Commit-Position: refs/heads/master@{#421264}