content/browser/service_worker/service_worker_version.h - Issue 2365053002: Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2365053002: Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates. (Closed)

Patch Set: rebase, rename Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 087ebe5ba0918e7c09be1a5ffeea2e956a7809c3..5026700bcbe09f5a78f3a83a27c1700d9fe29a70 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -102,6 +102,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

public:

virtual void OnRunningStateChanged(ServiceWorkerVersion* version) {}

virtual void OnVersionStateChanged(ServiceWorkerVersion* version) {}

+ virtual void OnDevToolsRoutingIdChanged(ServiceWorkerVersion* version) {}

virtual void OnMainScriptHttpResponseInfoSet(

ServiceWorkerVersion* version) {}

virtual void OnErrorReported(ServiceWorkerVersion* version,

@@ -554,6 +555,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

void OnDetached(EmbeddedWorkerStatus old_status) override;

void OnScriptLoaded() override;

void OnScriptLoadFailed() override;

+ void OnRegisteredToDevToolsManager() override;

void OnReportException(const base::string16& error_message,

int line_number,

int column_number,