Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/browser/frame_host/navigator.h

Issue 2364943002: Create NavigationHandles for interstitials if needed (Closed)
Patch Set: Addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 05caf6abbd14b30c27ba13b4e8e0249b4ca0ab43..af73ab47cedf1fa169dba8314f85b6a659ebfe05 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -27,6 +27,7 @@ class FrameNavigationEntry;
class FrameTreeNode;
class NavigationControllerImpl;
class NavigationEntryImpl;
+class NavigationHandleImpl;
class NavigationRequest;
class RenderFrameHostImpl;
class ResourceRequestBodyImpl;
@@ -179,6 +180,14 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
const base::TimeTicks& renderer_before_unload_start_time,
const base::TimeTicks& renderer_before_unload_end_time) {}
+ // Returns the NavigationHandle associated to a navigation in
nasko 2016/09/26 15:51:50 minor nit: associated with
clamy 2016/09/26 16:27:28 Done.
+ // |render_frame_host|. Normally, each frame can have its own
+ // NavigationHandle. However, in the case of a navigation to an interstitial
+ // page, there's just one NavigationHandle for the whole page (since it's
+ // assumed to only have one RenderFrameHost and navigate once).
+ virtual NavigationHandleImpl* GetNavigationHandleForFrameHost(
+ RenderFrameHostImpl* render_frame_host);
+
protected:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}

Powered by Google App Engine
This is Rietveld 408576698