Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 2364943002: Create NavigationHandles for interstitials if needed (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigator_delegate.h" 10 #include "content/browser/frame_host/navigator_delegate.h"
11 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 #include "content/public/browser/navigation_controller.h" 12 #include "content/public/browser/navigation_controller.h"
13 #include "ui/base/window_open_disposition.h" 13 #include "ui/base/window_open_disposition.h"
14 14
15 class GURL; 15 class GURL;
16 struct FrameHostMsg_BeginNavigation_Params; 16 struct FrameHostMsg_BeginNavigation_Params;
17 struct FrameHostMsg_DidCommitProvisionalLoad_Params; 17 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
18 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params; 18 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
19 19
20 namespace base { 20 namespace base {
21 class TimeTicks; 21 class TimeTicks;
22 } 22 }
23 23
24 namespace content { 24 namespace content {
25 25
26 class FrameNavigationEntry; 26 class FrameNavigationEntry;
27 class FrameTreeNode; 27 class FrameTreeNode;
28 class NavigationControllerImpl; 28 class NavigationControllerImpl;
29 class NavigationEntryImpl; 29 class NavigationEntryImpl;
30 class NavigationHandleImpl;
30 class NavigationRequest; 31 class NavigationRequest;
31 class RenderFrameHostImpl; 32 class RenderFrameHostImpl;
32 class ResourceRequestBodyImpl; 33 class ResourceRequestBodyImpl;
33 class StreamHandle; 34 class StreamHandle;
34 struct BeginNavigationParams; 35 struct BeginNavigationParams;
35 struct CommonNavigationParams; 36 struct CommonNavigationParams;
36 struct ResourceResponse; 37 struct ResourceResponse;
37 38
38 // Implementations of this interface are responsible for performing navigations 39 // Implementations of this interface are responsible for performing navigations
39 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode 40 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // conventions. 173 // conventions.
173 virtual void LogResourceRequestTime( 174 virtual void LogResourceRequestTime(
174 base::TimeTicks timestamp, const GURL& url) {}; 175 base::TimeTicks timestamp, const GURL& url) {};
175 176
176 // Called to record the time it took to execute the before unload hook for the 177 // Called to record the time it took to execute the before unload hook for the
177 // current navigation. 178 // current navigation.
178 virtual void LogBeforeUnloadTime( 179 virtual void LogBeforeUnloadTime(
179 const base::TimeTicks& renderer_before_unload_start_time, 180 const base::TimeTicks& renderer_before_unload_start_time,
180 const base::TimeTicks& renderer_before_unload_end_time) {} 181 const base::TimeTicks& renderer_before_unload_end_time) {}
181 182
183 // Returns the NavigationHandle associated to a navigation in
nasko 2016/09/26 15:51:50 minor nit: associated with
clamy 2016/09/26 16:27:28 Done.
184 // |render_frame_host|. Normally, each frame can have its own
185 // NavigationHandle. However, in the case of a navigation to an interstitial
186 // page, there's just one NavigationHandle for the whole page (since it's
187 // assumed to only have one RenderFrameHost and navigate once).
188 virtual NavigationHandleImpl* GetNavigationHandleForFrameHost(
189 RenderFrameHostImpl* render_frame_host);
190
182 protected: 191 protected:
183 friend class base::RefCounted<Navigator>; 192 friend class base::RefCounted<Navigator>;
184 virtual ~Navigator() {} 193 virtual ~Navigator() {}
185 }; 194 };
186 195
187 } // namespace content 196 } // namespace content
188 197
189 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 198 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698