Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2364933002: cocoa browser: remove non-material omnibox support (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: remove non-material omnibox support This is part 3 of removing non-material top chrome support. BUG=649368 Committed: https://crrev.com/8768302e2af9cf77a2c09114d6daf9ae61e6aa37 Cr-Commit-Position: refs/heads/master@{#420684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -129 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 11 chunks +24 lines, -81 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 5 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 6 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
avi: ptal? :)
4 years, 3 months ago (2016-09-23 14:25:01 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 3 months ago (2016-09-23 18:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364933002/1
4 years, 3 months ago (2016-09-23 18:24:11 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-09-23 19:04:23 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:04:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8768302e2af9cf77a2c09114d6daf9ae61e6aa37
Cr-Commit-Position: refs/heads/master@{#420684}

Powered by Google App Engine
This is Rietveld 408576698