Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2364933002: cocoa browser: remove non-material omnibox support (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index 62821090b35cc488e483bb06132d7f62d88b76b2..5b3204c4faab8eccd2339275f5a33faec6d3dad0 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -80,7 +80,6 @@
namespace {
const int kOmniboxLargeFontSizeDelta = 9;
const int kOmniboxNormalFontSizeDelta = 1;
-const int kOmniboxSmallFontSizeDelta = 0;
const int kOmniboxSmallMaterialFontSizeDelta = -1;
// TODO(shess): This is ugly, find a better way. Using it right now
@@ -97,15 +96,9 @@
}
NSColor* HostTextColor(bool in_dark_mode) {
- if (!ui::MaterialDesignController::IsModeMaterial()) {
- return [NSColor blackColor];
- }
return in_dark_mode ? [NSColor whiteColor] : [NSColor blackColor];
}
NSColor* SecureSchemeColor(bool in_dark_mode) {
- if (!ui::MaterialDesignController::IsModeMaterial()) {
- return ColorWithRGBBytes(0x07, 0x95, 0x00);
- }
return in_dark_mode ? skia::SkColorToSRGBNSColor(SK_ColorWHITE)
: skia::SkColorToSRGBNSColor(gfx::kGoogleGreen700);
}
@@ -115,9 +108,6 @@
: skia::SkColorToSRGBNSColor(gfx::kGoogleYellow700);
}
NSColor* SecurityErrorSchemeColor(bool in_dark_mode) {
- if (!ui::MaterialDesignController::IsModeMaterial()) {
- return ColorWithRGBBytes(0xa2, 0x00, 0x00);
- }
return in_dark_mode
? skia::SkColorToSRGBNSColor(SkColorSetA(SK_ColorWHITE, 0x7F))
: skia::SkColorToSRGBNSColor(gfx::kGoogleRed700);
@@ -180,9 +170,6 @@ NSRange ComponentToNSRange(const url::Component& component) {
// static
NSColor* OmniboxViewMac::BaseTextColor(bool in_dark_mode) {
- if (!ui::MaterialDesignController::IsModeMaterial()) {
- return [NSColor darkGrayColor];
- }
return skia::SkColorToSRGBNSColor(BaseTextColorSkia(in_dark_mode));
}
@@ -585,11 +572,9 @@ NSRange ComponentToNSRange(const url::Component& component) {
value:@"en_US_POSIX"
range:as_entire_string];
- if (ui::MaterialDesignController::IsModeMaterial()) {
- [attributedString addAttribute:NSForegroundColorAttributeName
- value:HostTextColor(in_dark_mode)
- range:as_entire_string];
- }
+ [attributedString addAttribute:NSForegroundColorAttributeName
+ value:HostTextColor(in_dark_mode)
+ range:as_entire_string];
url::Component scheme, host;
AutocompleteInput::ParseForEmphasizeComponents(
@@ -1100,15 +1085,7 @@ NSRange ComponentToNSRange(const url::Component& component) {
}
NSFont* OmniboxViewMac::GetSmallFont() {
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- if (!ui::MaterialDesignController::IsModeMaterial()) {
- return rb
- .GetFontWithDelta(kOmniboxSmallFontSizeDelta, gfx::Font::NORMAL,
- gfx::Font::Weight::NORMAL)
- .GetNativeFont();
- }
-
- return rb
+ return ui::ResourceBundle::GetSharedInstance()
.GetFontWithDelta(kOmniboxSmallMaterialFontSizeDelta, gfx::Font::NORMAL,
gfx::Font::Weight::NORMAL)
.GetNativeFont();
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698