Add Precache.CacheStatus.NonPrefetch.FromPrecache.

Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG=650773
Committed: https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de
Cr-Commit-Position: refs/heads/master@{#423892}

[twifkak, 2016-09-23 22:59:11]

twifkak@chromium.org changed reviewers:
+ jamartin@chromium.org, rajendrant@chromium.org

[twifkak, 2016-09-23 22:59:11]

Raj/Jose: Does this make sense? Also see the note in my CL description. Sending
this as a first draft to you before I add a metrics owner.

[chromium-reviews, 2016-09-24 00:12:52]

I won't be able to review this until this Tuesday. I'll delegate on Raj
until then.

On Sat, Sep 24, 2016 at 12:59 AM <twifkak@chromium.org> wrote:

> Reviewers: Raj, jamartin
> CL: https://codereview.chromium.org/2364873004/
>
> Message:
> Raj/Jose: Does this make sense? Also see the note in my CL description.
> Sending
> this as a first draft to you before I add a metrics owner.
>
> Description:
> Add Precache.CacheStatus.NonPrefetch.FromPrecache.
>
> This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
> where the URL matches an unused entry in the precache_urls table -- that
> is, first requests for URLs retrieved as part of prefetching. Misses
> would be reported by this metric as a result of expiration or eviction.
>
> Note to reviewers:
>
> Ideally, I would report this not just for first requests for precached
> URLs, but for all requests. This should cause the metrics sampled to be
> weighted similarly to HttpCache.Pattern. This will require a
> PrecacheURLTable API change (to retrieve is_precached and was_used in
> the SELECT rather than condition on them in the WHERE).
>
> 1) Is my ideal correct?
> 2) Should I make the API change?
>
> BUG=
>
> Affected files (+25, -0 lines):
> M components/precache/core/precache_database.cc
> M components/precache/core/precache_database_unittest.cc
> M tools/metrics/histograms/histograms.xml
>
>
> Index: components/precache/core/precache_database.cc
> diff --git a/components/precache/core/precache_database.cc
> b/components/precache/core/precache_database.cc
> index
>
f513410c98cea69b06a3edfd4f2dcdf32df4b16e..10f231fed8cff6a2a7e73bc0a275ae79823e90aa
> 100644
> --- a/components/precache/core/precache_database.cc
> +++ b/components/precache/core/precache_database.cc
> @@ -256,6 +256,12 @@ void PrecacheDatabase::RecordURLNonPrefetch(const
> GURL& url,
> return;
> }
>
> + if (is_precached)
> + UMA_HISTOGRAM_ENUMERATION(
> + "Precache.CacheStatus.NonPrefetch.FromPrecache",
> + info.cache_entry_status,
> + net::HttpResponseInfo::CacheEntryStatus::ENTRY_MAX);
> +
> base::HistogramBase::Sample size_sample =
> static_cast<base::HistogramBase::Sample>(size);
> if (!info.was_cached) {
> Index: components/precache/core/precache_database_unittest.cc
> diff --git a/components/precache/core/precache_database_unittest.cc
> b/components/precache/core/precache_database_unittest.cc
> index
>
aa9fa26ed3b45cb4147677c2c15162cc82a844cb..8d00c79f6f6c0c36bc49e985454d235f5c118dd3
> 100644
> --- a/components/precache/core/precache_database_unittest.cc
> +++ b/components/precache/core/precache_database_unittest.cc
> @@ -101,6 +101,8 @@ class PrecacheDatabaseTest : public testing::Test {
> ASSERT_TRUE(precache_database_->Init(db_path));
> }
>
> + void TearDown() override { precache_url_table()->DeleteAll(); }
> +
> std::map<GURL, base::Time> GetActualURLTableMap() {
> // Flush any buffered writes so that the URL table will be up to date.
> precache_database_->Flush();
> @@ -335,6 +337,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchOverNetworkWithURLTableEntry) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts",
> kLatency.InMilliseconds());
> ExpectNewSample("Precache.CacheStatus.NonPrefetch", kFromNetwork);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + kFromNetwork);
> ExpectNoOtherSamples();
> }
>
> @@ -349,6 +353,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchFromCacheWithURLTableEntry_NonCellular) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts", 0);
> ExpectNewSample("Precache.CacheStatus.NonPrefetch",
> HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> ExpectNewSample("Precache.Saved", kSize);
> ExpectNewSample("Precache.Saved.Freshness", kFreshnessBucket10K);
> ExpectNoOtherSamples();
> @@ -365,6 +371,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchFromCacheWithURLTableEntry_Cellular) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts", 0);
> ExpectNewSample("Precache.CacheStatus.NonPrefetch",
> HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> ExpectNewSample("Precache.Saved", kSize);
> ExpectNewSample("Precache.Saved.Cellular", kSize);
> ExpectNewSample("Precache.Saved.Freshness", kFreshnessBucket10K);
> Index: tools/metrics/histograms/histograms.xml
> diff --git a/tools/metrics/histograms/histograms.xml
> b/tools/metrics/histograms/histograms.xml
> index
>
4fd1a7941c3d029237eacdd0f14768df4234c2a4..531e11a57eebe8cd9bc3fa5037700fc3c416e7be
> 100644
> --- a/tools/metrics/histograms/histograms.xml
> +++ b/tools/metrics/histograms/histograms.xml
> @@ -45327,6 +45327,17 @@ http://cs/file:chrome/histograms.xml - but
> prefer this file for new entries.
> </summary>
> </histogram>
>
> +<histogram name="Precache.CacheStatus.NonPrefetch.FromPrecache"
> + enum="HttpCachePattern">
> + <owner>jamartin@chromium.org</owner&gt;
> + <owner>bengr@chromium.org</owner&gt;
> + <summary>
> + Like Precache.CacheStatus.NonPrefetch but only for requests which having
> a
> + matching URL in the precache. Measures the amount of precache misses due
> to
> + expiration or eviction. Logged per-request.
> + </summary>
> +</histogram>
> +
> <histogram name="Precache.DownloadedNonPrecache" units="bytes">
> <owner>bengr@chromium.org</owner&gt;
> <summary>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-09-24 00:23:28]

So, if I understand correctly, you want to know HttpCache.Pattern for
non-prefetch URLs that were precached in the previous cycle and may or may
not be in the cache anymore due to expirations and evictions, correct?

If that is the case, I think your analysis and approach are correct,
although I'm not familiar with the URL database, so maybe Raj has something
to say on that side.

I can look deeper on Tuesday, if you need me to.

On Sat, Sep 24, 2016 at 2:12 AM Jose Martin <jamartin@google.com> wrote:

> I won't be able to review this until this Tuesday. I'll delegate on Raj
> until then.
>
> On Sat, Sep 24, 2016 at 12:59 AM <twifkak@chromium.org> wrote:
>
> Reviewers: Raj, jamartin
> CL: https://codereview.chromium.org/2364873004/
>
> Message:
> Raj/Jose: Does this make sense? Also see the note in my CL description.
> Sending
> this as a first draft to you before I add a metrics owner.
>
> Description:
> Add Precache.CacheStatus.NonPrefetch.FromPrecache.
>
> This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
> where the URL matches an unused entry in the precache_urls table -- that
> is, first requests for URLs retrieved as part of prefetching. Misses
> would be reported by this metric as a result of expiration or eviction.
>
> Note to reviewers:
>
> Ideally, I would report this not just for first requests for precached
> URLs, but for all requests. This should cause the metrics sampled to be
> weighted similarly to HttpCache.Pattern. This will require a
> PrecacheURLTable API change (to retrieve is_precached and was_used in
> the SELECT rather than condition on them in the WHERE).
>
> 1) Is my ideal correct?
> 2) Should I make the API change?
>
> BUG=
>
> Affected files (+25, -0 lines):
> M components/precache/core/precache_database.cc
> M components/precache/core/precache_database_unittest.cc
> M tools/metrics/histograms/histograms.xml
>
>
> Index: components/precache/core/precache_database.cc
> diff --git a/components/precache/core/precache_database.cc
> b/components/precache/core/precache_database.cc
> index
>
f513410c98cea69b06a3edfd4f2dcdf32df4b16e..10f231fed8cff6a2a7e73bc0a275ae79823e90aa
> 100644
> --- a/components/precache/core/precache_database.cc
> +++ b/components/precache/core/precache_database.cc
> @@ -256,6 +256,12 @@ void PrecacheDatabase::RecordURLNonPrefetch(const
> GURL& url,
> return;
> }
>
> + if (is_precached)
> + UMA_HISTOGRAM_ENUMERATION(
> + "Precache.CacheStatus.NonPrefetch.FromPrecache",
> + info.cache_entry_status,
> + net::HttpResponseInfo::CacheEntryStatus::ENTRY_MAX);
> +
> base::HistogramBase::Sample size_sample =
> static_cast<base::HistogramBase::Sample>(size);
> if (!info.was_cached) {
> Index: components/precache/core/precache_database_unittest.cc
> diff --git a/components/precache/core/precache_database_unittest.cc
> b/components/precache/core/precache_database_unittest.cc
> index
>
aa9fa26ed3b45cb4147677c2c15162cc82a844cb..8d00c79f6f6c0c36bc49e985454d235f5c118dd3
> 100644
> --- a/components/precache/core/precache_database_unittest.cc
> +++ b/components/precache/core/precache_database_unittest.cc
> @@ -101,6 +101,8 @@ class PrecacheDatabaseTest : public testing::Test {
> ASSERT_TRUE(precache_database_->Init(db_path));
> }
>
> + void TearDown() override { precache_url_table()->DeleteAll(); }
> +
> std::map<GURL, base::Time> GetActualURLTableMap() {
> // Flush any buffered writes so that the URL table will be up to date.
> precache_database_->Flush();
> @@ -335,6 +337,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchOverNetworkWithURLTableEntry) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts",
> kLatency.InMilliseconds());
> ExpectNewSample("Precache.CacheStatus.NonPrefetch", kFromNetwork);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + kFromNetwork);
> ExpectNoOtherSamples();
> }
>
> @@ -349,6 +353,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchFromCacheWithURLTableEntry_NonCellular) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts", 0);
> ExpectNewSample("Precache.CacheStatus.NonPrefetch",
> HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> ExpectNewSample("Precache.Saved", kSize);
> ExpectNewSample("Precache.Saved.Freshness", kFreshnessBucket10K);
> ExpectNoOtherSamples();
> @@ -365,6 +371,8 @@ TEST_F(PrecacheDatabaseTest,
> FetchFromCacheWithURLTableEntry_Cellular) {
> ExpectNewSample("Precache.Latency.NonPrefetch.NonTopHosts", 0);
> ExpectNewSample("Precache.CacheStatus.NonPrefetch",
> HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> + ExpectNewSample("Precache.CacheStatus.NonPrefetch.FromPrecache",
> + HttpResponseInfo::CacheEntryStatus::ENTRY_USED);
> ExpectNewSample("Precache.Saved", kSize);
> ExpectNewSample("Precache.Saved.Cellular", kSize);
> ExpectNewSample("Precache.Saved.Freshness", kFreshnessBucket10K);
> Index: tools/metrics/histograms/histograms.xml
> diff --git a/tools/metrics/histograms/histograms.xml
> b/tools/metrics/histograms/histograms.xml
> index
>
4fd1a7941c3d029237eacdd0f14768df4234c2a4..531e11a57eebe8cd9bc3fa5037700fc3c416e7be
> 100644
> --- a/tools/metrics/histograms/histograms.xml
> +++ b/tools/metrics/histograms/histograms.xml
> @@ -45327,6 +45327,17 @@ http://cs/file:chrome/histograms.xml - but
> prefer this file for new entries.
> </summary>
> </histogram>
>
> +<histogram name="Precache.CacheStatus.NonPrefetch.FromPrecache"
> + enum="HttpCachePattern">
> + <owner>jamartin@chromium.org</owner&gt;
> + <owner>bengr@chromium.org</owner&gt;
> + <summary>
> + Like Precache.CacheStatus.NonPrefetch but only for requests which having
> a
> + matching URL in the precache. Measures the amount of precache misses due
> to
> + expiration or eviction. Logged per-request.
> + </summary>
> +</histogram>
> +
> <histogram name="Precache.DownloadedNonPrecache" units="bytes">
> <owner>bengr@chromium.org</owner&gt;
> <summary>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Raj, 2016-09-26 22:09:58]

lgtm

https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
File components/precache/core/precache_database.cc (right):

https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
components/precache/core/precache_database.cc:259: if (is_precached)
nit: add the multiline statement inside parentheses.

[twifkak, 2016-09-26 22:57:04]

twifkak@chromium.org changed reviewers:
+ rkaplow@chromium.org

[twifkak, 2016-09-26 22:57:05]

Raj: Did you take a look at the "Note to reviewers" in my commit description? Do
you have an opinion? If not, I'll perform the API change I suggest.

rkaplow: Please review histograms.xml.

Thanks!

https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
File components/precache/core/precache_database.cc (right):

https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
components/precache/core/precache_database.cc:259: if (is_precached)
On 2016/09/26 22:09:58, Raj wrote:
> nit: add the multiline statement inside parentheses.

Done.

[twifkak, 2016-09-27 18:46:21]

Description was changed from

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Note to reviewers:

Ideally, I would report this not just for first requests for precached
URLs, but for all requests. This should cause the metrics sampled to be
weighted similarly to HttpCache.Pattern. This will require a
PrecacheURLTable API change (to retrieve is_precached and was_used in
the SELECT rather than condition on them in the WHERE).

1) Is my ideal correct?
2) Should I make the API change?

BUG=
==========

to

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Note to reviewers:

Ideally, I would report this not just for first requests for precached
URLs, but for all requests. This should cause the metrics sampled to be
weighted similarly to HttpCache.Pattern. This will require a
PrecacheURLTable API change (to retrieve is_precached and was_used in
the SELECT rather than condition on them in the WHERE).

1) Is my ideal correct?
2) Should I make the API change?

BUG=650773
==========

[rkaplow, 2016-09-28 14:11:48]

rkaplow@chromium.org changed reviewers:
+ gayane@chromium.org
- rkaplow@chromium.org

[gayane -on leave until 09-2017, 2016-09-28 15:38:57]

lgtm

[Raj, 2016-09-28 18:21:36]

On 2016/09/26 22:57:05, twifkak wrote:
> Raj: Did you take a look at the "Note to reviewers" in my commit description?
Do
> you have an opinion? If not, I'll perform the API change I suggest.
> 
> rkaplow: Please review histograms.xml.
> 
> Thanks!
> 
>
https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
> File components/precache/core/precache_database.cc (right):
> 
>
https://codereview.chromium.org/2364873004/diff/1/components/precache/core/pr...
> components/precache/core/precache_database.cc:259: if (is_precached)
> On 2016/09/26 22:09:58, Raj wrote:
> > nit: add the multiline statement inside parentheses.
> 
> Done.

Sorry for delay.
Yes. The note in your commit description makes sense.

From your/Jose's comments, you want to know HttpCache.Pattern for
non-prefetch URLs that were precached in the previous cycles and may or may
not be in the cache anymore due to expirations and evictions.

Just to note, the URL table only has precached URLs, and not all URLs from
manifest.

[chromium-reviews, 2016-09-28 18:29:34]

On Wed, Sep 28, 2016 at 11:21 AM, <rajendrant@chromium.org> wrote:

> Sorry for delay.
>
No worries.


> Just to note, the URL table only has precached URLs, and not all URLs from
> manifest.
>
To be clear, the difference you're referring to is our limits on # of
resources and # of bytes to download?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Raj, 2016-09-28 18:40:17]

On 2016/09/28 18:29:34, chromium-reviews wrote:
> On Wed, Sep 28, 2016 at 11:21 AM, <mailto:rajendrant@chromium.org> wrote:
> 
> > Sorry for delay.
> >
> No worries.
> 
> 
> > Just to note, the URL table only has precached URLs, and not all URLs from
> > manifest.
> >
> To be clear, the difference you're referring to is our limits on # of
> resources and # of bytes to download?
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Yes. Those limits and cancellations.

[chromium-reviews, 2016-09-28 18:53:13]

OK, thanks, yup I think those should be ignored for the sake of this
metric, since they don't take up space in the cache, with the possible
exception of partial downloads. (All in all, the more I think about this
metric, the harder it is for me to define in a way that ensures complete
peace of mind, but some number is better than none.)

On Wed, Sep 28, 2016 at 11:40 AM, <rajendrant@chromium.org> wrote:

> On 2016/09/28 18:29:34, chromium-reviews wrote:
> > On Wed, Sep 28, 2016 at 11:21 AM, <mailto:rajendrant@chromium.org>
> wrote:
> >
> > > Sorry for delay.
> > >
> > No worries.
> >
> >
> > > Just to note, the URL table only has precached URLs, and not all URLs
> from
> > > manifest.
> > >
> > To be clear, the difference you're referring to is our limits on # of
> > resources and # of bytes to download?
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> Yes. Those limits and cancellations.
>
> https://codereview.chromium.org/2364873004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[twifkak, 2016-09-28 23:07:45]

Description was changed from

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Note to reviewers:

Ideally, I would report this not just for first requests for precached
URLs, but for all requests. This should cause the metrics sampled to be
weighted similarly to HttpCache.Pattern. This will require a
PrecacheURLTable API change (to retrieve is_precached and was_used in
the SELECT rather than condition on them in the WHERE).

1) Is my ideal correct?
2) Should I make the API change?

BUG=650773
==========

to

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG=650773
==========

[twifkak, 2016-09-28 23:30:02]

Raj: PTAL (patch sets 3 and 5) when you have the time. Thanks!

[twifkak, 2016-10-03 20:37:12]

The CQ bit was checked by twifkak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:15:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[twifkak, 2016-10-03 23:50:09]

The CQ bit was checked by twifkak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:51:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 02:05:19]

Dry run: This issue passed the CQ dry run.

[twifkak, 2016-10-04 21:58:16]

The CQ bit was checked by twifkak@chromium.org

[twifkak, 2016-10-04 21:58:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
rajendrant@chromium.org, gayane@chromium.org
Link to the patchset: https://codereview.chromium.org/2364873004/#ps120001
(title: "Add const.")

[commit-bot: I haz the power, 2016-10-04 21:58:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:12:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[twifkak, 2016-10-04 22:16:57]

twifkak@chromium.org changed reviewers:
+ jwd@chromium.org

[twifkak, 2016-10-04 22:16:58]

jwd: Please review for tools/metrics/histograms/histograms.xml.

[Raj, 2016-10-05 17:25:45]

On 2016/10/04 22:16:58, twifkak wrote:
> jwd: Please review for tools/metrics/histograms/histograms.xml.

lgtm

[twifkak, 2016-10-06 20:40:11]

jwd: Friendly ping. I need an OWNERS lg for histograms.xml.

[jwd, 2016-10-07 15:08:11]

lgtm

[twifkak, 2016-10-07 16:06:36]

The CQ bit was checked by twifkak@chromium.org

[commit-bot: I haz the power, 2016-10-07 16:07:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:12:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-07 17:14:31]

Description was changed from

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG=650773
==========

to

==========
Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG=650773

Committed: https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de
Cr-Commit-Position: refs/heads/master@{#423892}
==========

[commit-bot: I haz the power, 2016-10-07 17:14:33]

Patchset 7 (id:??) landed as
https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de
Cr-Commit-Position: refs/heads/master@{#423892}