Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2364733004: Remove the proguard keep rule for AwDebug now @UsedByReflection works. (Closed)

Created:
4 years, 3 months ago by Tobias Sargeant
Modified:
4 years, 3 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the proguard keep rule for AwDebug now @UsedByReflection works. BUG=541543 Committed: https://crrev.com/e8bb027218d9aaa48c29ef67bc989ca1ce69148e Cr-Commit-Position: refs/heads/master@{#420612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M android_webview/apk/java/proguard.flags View 1 chunk +0 lines, -5 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwDebug.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tobias Sargeant
4 years, 3 months ago (2016-09-23 12:58:59 UTC) #2
Torne
4 years, 3 months ago (2016-09-23 13:13:59 UTC) #3
Torne
lgtm
4 years, 3 months ago (2016-09-23 13:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364733004/1
4 years, 3 months ago (2016-09-23 13:14:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 13:33:21 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:35:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8bb027218d9aaa48c29ef67bc989ca1ce69148e
Cr-Commit-Position: refs/heads/master@{#420612}

Powered by Google App Engine
This is Rietveld 408576698