Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: android_webview/apk/java/proguard.flags

Issue 2364733004: Remove the proguard keep rule for AwDebug now @UsedByReflection works. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwDebug.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Don't rename anything, it makes stack traces unintelligible. We only allow the 1 # Don't rename anything, it makes stack traces unintelligible. We only allow the
2 # obfuscation pass to run so that we can discard attributes like local variable 2 # obfuscation pass to run so that we can discard attributes like local variable
3 # tables. However, we don't want to lose out on optimizations, so although they 3 # tables. However, we don't want to lose out on optimizations, so although they
4 # can occasionally make the stack trace a bit stranger with inlining, it won't 4 # can occasionally make the stack trace a bit stranger with inlining, it won't
5 # make a big difference for the users seeing the stacktraces. We can always use 5 # make a big difference for the users seeing the stacktraces. We can always use
6 # build/android/stacktrace/java_deobfuscate.py to fix the stacktrace up for us. 6 # build/android/stacktrace/java_deobfuscate.py to fix the stacktrace up for us.
7 -keepnames,allowoptimization class *** { *; } 7 -keepnames,allowoptimization class *** { *; }
8 8
9 # Keep the factory and its public members; it's the main entry point used by the 9 # Keep the factory and its public members; it's the main entry point used by the
10 # framework. 10 # framework.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 void onHideCustomView(); 43 void onHideCustomView();
44 } 44 }
45 45
46 # Accessed via reflection but not present in all builds 46 # Accessed via reflection but not present in all builds
47 -keep class com.android.webview.chromium.PlatformServiceBridgeGoogle { 47 -keep class com.android.webview.chromium.PlatformServiceBridgeGoogle {
48 void setMetricsSettingListener(...); 48 void setMetricsSettingListener(...);
49 PlatformServiceBridgeGoogle(...); 49 PlatformServiceBridgeGoogle(...);
50 } 50 }
51 -dontnote com.android.webview.chromium.PlatformServiceBridgeGoogle 51 -dontnote com.android.webview.chromium.PlatformServiceBridgeGoogle
52 52
53 # AwDebug is accessed by reflection.
54 -keep class org.chromium.android_webview.AwDebug {
55 public static boolean dumpWithoutCrashing(...);
56 }
57
58 #TODO(hush): remove after N release. crbug.com/546762 53 #TODO(hush): remove after N release. crbug.com/546762
59 -keep class com.android.webview.chromium.ContentSettingsAdapter { 54 -keep class com.android.webview.chromium.ContentSettingsAdapter {
60 public void setDisabledActionModeMenuItems(int); 55 public void setDisabledActionModeMenuItems(int);
61 public int getDisabledActionModeMenuItems(); 56 public int getDisabledActionModeMenuItems();
62 } 57 }
OLDNEW
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwDebug.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698