Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2364733002: Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. There are no positives in analyzer/server, dev_compiler or dart2js. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27300 Committed: https://github.com/dart-lang/sdk/commit/77ba5fd0871ecec19fc06806d5c2649de95f9b7c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes for false positives. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -30 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 4 chunks +3 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 8 chunks +52 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 3 months ago (2016-09-22 19:52:49 UTC) #1
Brian Wilkerson
lgtm, as long as the test I proposed passes https://codereview.chromium.org/2364733002/diff/1/pkg/analyzer/test/generated/hint_code_test.dart File pkg/analyzer/test/generated/hint_code_test.dart (right): https://codereview.chromium.org/2364733002/diff/1/pkg/analyzer/test/generated/hint_code_test.dart#newcode68 pkg/analyzer/test/generated/hint_code_test.dart:68: ...
4 years, 3 months ago (2016-09-22 20:06:04 UTC) #2
scheglov
PTAL The negative test, that you asked to check for, was false positive. I fixed ...
4 years, 3 months ago (2016-09-22 20:58:41 UTC) #3
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-22 21:13:34 UTC) #4
scheglov
4 years, 3 months ago (2016-09-22 21:27:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
77ba5fd0871ecec19fc06806d5c2649de95f9b7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698