Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2364733002: Issue 27300. Report HintCode.ABSTRACT_SUPER_MEMBER_REFERENCE. (Closed)
Patch Set: Fixes for false positives. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.task.dart; 5 library analyzer.src.task.dart;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/token.dart'; 10 import 'package:analyzer/dart/ast/token.dart';
(...skipping 3142 matching lines...) Expand 10 before | Expand all | Expand 10 after
3153 if (analysisOptions.dart2jsHint) { 3153 if (analysisOptions.dart2jsHint) {
3154 unit.accept(new Dart2JSVerifier(errorReporter)); 3154 unit.accept(new Dart2JSVerifier(errorReporter));
3155 } 3155 }
3156 // Dart best practices. 3156 // Dart best practices.
3157 InheritanceManager inheritanceManager = new InheritanceManager( 3157 InheritanceManager inheritanceManager = new InheritanceManager(
3158 libraryElement, 3158 libraryElement,
3159 includeAbstractFromSuperclasses: true); 3159 includeAbstractFromSuperclasses: true);
3160 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT); 3160 TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);
3161 3161
3162 unit.accept(new BestPracticesVerifier( 3162 unit.accept(new BestPracticesVerifier(
3163 errorReporter, typeProvider, libraryElement, 3163 errorReporter, typeProvider, libraryElement, inheritanceManager,
3164 typeSystem: typeSystem)); 3164 typeSystem: typeSystem));
3165 unit.accept(new OverrideVerifier(errorReporter, inheritanceManager)); 3165 unit.accept(new OverrideVerifier(errorReporter, inheritanceManager));
3166 // Find to-do comments. 3166 // Find to-do comments.
3167 new ToDoFinder(errorReporter).findIn(unit); 3167 new ToDoFinder(errorReporter).findIn(unit);
3168 // 3168 //
3169 // Record outputs. 3169 // Record outputs.
3170 // 3170 //
3171 outputs[HINTS] = errorListener.errors; 3171 outputs[HINTS] = errorListener.errors;
3172 } 3172 }
3173 3173
(...skipping 3258 matching lines...) Expand 10 before | Expand all | Expand 10 after
6432 6432
6433 @override 6433 @override
6434 bool moveNext() { 6434 bool moveNext() {
6435 if (_newSources.isEmpty) { 6435 if (_newSources.isEmpty) {
6436 return false; 6436 return false;
6437 } 6437 }
6438 currentTarget = _newSources.removeLast(); 6438 currentTarget = _newSources.removeLast();
6439 return true; 6439 return true;
6440 } 6440 }
6441 } 6441 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/test/generated/hint_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698