Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2364603002: Revert of [heap] Reland Concurrently free empty typed slot set chunks. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Reland Concurrently free empty typed slot set chunks. (patchset #2 id:20001 of https://codereview.chromium.org/2365603002/ ) Reason for revert: Leaks and TSAN: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/15441 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11867 Original issue's description: > [heap] Reland Concurrently free empty typed slot set chunks. > > BUG=chromium:648568 > > Committed: https://crrev.com/ec3835751d678c0b4a3fda47d11ffa107cd27e23 > Cr-Commit-Position: refs/heads/master@{#39630} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Committed: https://crrev.com/20caa8770ac3223a0f80834329dddde50c3cb4a0 Cr-Commit-Position: refs/heads/master@{#39632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -83 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/remembered-set.h View 2 chunks +5 lines, -8 lines 0 comments Download
M src/heap/remembered-set.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/slot-set.h View 6 chunks +1 line, -37 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 chunk +16 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Reland Concurrently free empty typed slot set chunks.
4 years, 3 months ago (2016-09-22 15:14:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364603002/1
4 years, 3 months ago (2016-09-22 15:14:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 15:14:49 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:15:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20caa8770ac3223a0f80834329dddde50c3cb4a0
Cr-Commit-Position: refs/heads/master@{#39632}

Powered by Google App Engine
This is Rietveld 408576698