Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2364543002: Revert of Image Capture Linux/CrOs: wire some capabilities set/get (Closed)

Created:
4 years, 3 months ago by Henrik Grunell
Modified:
4 years, 3 months ago
Reviewers:
mcasas, xianglu
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Image Capture Linux/CrOs: wire some capabilities set/get (patchset #3 id:100001 of https://codereview.chromium.org/2349693003/ ) Reason for revert: Broken WebRTC tests VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/0 VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/1 VideoCaptureDeviceTest.GetPhotoCapabilities on https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester Original issue's description: > Image Capture Linux/CrOs: wire some capabilities set/get > > This CL implements for Linux/Cros parts of the methods: > - VideoCaptureDeviceWin::GetPhotoCapabilities(): > zoom, autofocus on/off, autoexposure on/off, and > auto whitebalance on/off > - VideoCaptureDeviceWin::SetPhotoOptions(): zoom > > and adds a small VideoCaptureDeviceTest test case > to retrieve capabilities, enabled for Linux (should be > enabled for Android in another CL). > > BUG=647352 > > Committed: https://crrev.com/f457dee66ba0bfe49b67dee35b9fb8f3ec4f17e3 > Cr-Commit-Position: refs/heads/master@{#420229} TBR=xianglu@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647352 Committed: https://crrev.com/8fe050afbc28a120f4322bc3f4fe05f5fcc62d76 Cr-Commit-Position: refs/heads/master@{#420272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -167 lines) Patch
M media/capture/video/linux/v4l2_capture_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 5 chunks +1 line, -65 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Henrik Grunell
Created Revert of Image Capture Linux/CrOs: wire some capabilities set/get
4 years, 3 months ago (2016-09-22 06:41:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364543002/1
4 years, 3 months ago (2016-09-22 06:42:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 06:43:07 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 06:44:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fe050afbc28a120f4322bc3f4fe05f5fcc62d76
Cr-Commit-Position: refs/heads/master@{#420272}

Powered by Google App Engine
This is Rietveld 408576698