Chromium Code Reviews
DescriptionRevert of Image Capture Linux/CrOs: wire some capabilities set/get (patchset #3 id:100001 of https://codereview.chromium.org/2349693003/ )
Reason for revert:
Broken WebRTC tests
VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/0
VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/1
VideoCaptureDeviceTest.GetPhotoCapabilities
on
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester
Original issue's description:
> Image Capture Linux/CrOs: wire some capabilities set/get
>
> This CL implements for Linux/Cros parts of the methods:
> - VideoCaptureDeviceWin::GetPhotoCapabilities():
> zoom, autofocus on/off, autoexposure on/off, and
> auto whitebalance on/off
> - VideoCaptureDeviceWin::SetPhotoOptions(): zoom
>
> and adds a small VideoCaptureDeviceTest test case
> to retrieve capabilities, enabled for Linux (should be
> enabled for Android in another CL).
>
> BUG=647352
>
> Committed: https://crrev.com/f457dee66ba0bfe49b67dee35b9fb8f3ec4f17e3
> Cr-Commit-Position: refs/heads/master@{#420229}
TBR=xianglu@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647352
Committed: https://crrev.com/8fe050afbc28a120f4322bc3f4fe05f5fcc62d76
Cr-Commit-Position: refs/heads/master@{#420272}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||