Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: media/capture/video/video_capture_device_unittest.cc

Issue 2364543002: Revert of Image Capture Linux/CrOs: wire some capabilities set/get (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/capture/video/linux/video_capture_device_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/video_capture_device_unittest.cc
diff --git a/media/capture/video/video_capture_device_unittest.cc b/media/capture/video/video_capture_device_unittest.cc
index 05ef5a52627716fe9bae509be16f4f9bed661b46..11031fec944b74abf4c0bca026dcd47d6706e7fe 100644
--- a/media/capture/video/video_capture_device_unittest.cc
+++ b/media/capture/video/video_capture_device_unittest.cc
@@ -49,17 +49,14 @@
// We will always get YUYV from the Mac AVFoundation implementations.
#define MAYBE_CaptureMjpeg DISABLED_CaptureMjpeg
#define MAYBE_TakePhoto TakePhoto
-#define MAYBE_GetPhotoCapabilities DISABLED_GetPhotoCapabilities
#elif defined(OS_WIN)
#define MAYBE_AllocateBadSize AllocateBadSize
#define MAYBE_CaptureMjpeg CaptureMjpeg
#define MAYBE_TakePhoto TakePhoto
-#define MAYBE_GetPhotoCapabilities DISABLED_GetPhotoCapabilities
#elif defined(OS_ANDROID)
#define MAYBE_AllocateBadSize AllocateBadSize
#define MAYBE_CaptureMjpeg CaptureMjpeg
#define MAYBE_TakePhoto TakePhoto
-#define MAYBE_GetPhotoCapabilities GetPhotoCapabilities
#elif defined(OS_LINUX)
// AllocateBadSize will hang when a real camera is attached and if more than one
// test is trying to use the camera (even across processes). Do NOT renable
@@ -68,12 +65,10 @@
#define MAYBE_AllocateBadSize DISABLED_AllocateBadSize
#define MAYBE_CaptureMjpeg CaptureMjpeg
#define MAYBE_TakePhoto TakePhoto
-#define MAYBE_GetPhotoCapabilities GetPhotoCapabilities
#else
#define MAYBE_AllocateBadSize AllocateBadSize
#define MAYBE_CaptureMjpeg CaptureMjpeg
#define MAYBE_TakePhoto DISABLED_TakePhoto
-#define MAYBE_GetPhotoCapabilities DISABLED_GetPhotoCapabilities
#endif
using ::testing::_;
@@ -170,22 +165,9 @@
MOCK_METHOD1(OnTakePhotoFailure,
void(const base::Callback<void(mojom::BlobPtr)>&));
- // GMock doesn't support move-only arguments, so we use this forward method.
- void DoOnGetPhotoCapabilities(mojom::PhotoCapabilitiesPtr capabilities) {
- capabilities_ = std::move(capabilities);
- OnCorrectGetPhotoCapabilities();
- }
- MOCK_METHOD0(OnCorrectGetPhotoCapabilities, void(void));
- MOCK_METHOD1(OnGetPhotoCapabilitiesFailure,
- void(const base::Callback<void(mojom::PhotoCapabilitiesPtr)>&));
-
- const mojom::PhotoCapabilities* capabilities() { return capabilities_.get(); }
-
private:
friend class base::RefCounted<MockImageCaptureClient>;
virtual ~MockImageCaptureClient() {}
-
- mojom::PhotoCapabilitiesPtr capabilities_;
};
class DeviceEnumerationListener
@@ -532,7 +514,7 @@
ASSERT_FALSE(device_descriptor);
}
-// Starts the camera and takes a photo.
+// Starts the camera and take a photo.
TEST_F(VideoCaptureDeviceTest, MAYBE_TakePhoto) {
if (!EnumerateAndFindUsableDevices())
return;
@@ -572,50 +554,4 @@
device->StopAndDeAllocate();
}
-// Starts the camera and tries to get the Photo capabilities.
-TEST_F(VideoCaptureDeviceTest, MAYBE_GetPhotoCapabilities) {
- if (!EnumerateAndFindUsableDevices())
- return;
-
-#if defined(OS_ANDROID)
- // TODO(mcasas): fails on Lollipop devices, reconnect https://crbug.com/646840
- if (base::android::BuildInfo::GetInstance()->sdk_int() <
- base::android::SDK_VERSION_MARSHMALLOW) {
- return;
- }
-#endif
-
- std::unique_ptr<VideoCaptureDevice> device(
- video_capture_device_factory_->CreateDevice(
- device_descriptors_->front()));
- ASSERT_TRUE(device);
-
- EXPECT_CALL(*video_capture_client_, OnError(_, _)).Times(0);
-
- VideoCaptureParams capture_params;
- capture_params.requested_format.frame_size.SetSize(320, 240);
- capture_params.requested_format.frame_rate = 30;
- capture_params.requested_format.pixel_format = PIXEL_FORMAT_I420;
- device->AllocateAndStart(capture_params, std::move(video_capture_client_));
- WaitForCapturedFrame();
-
- VideoCaptureDevice::GetPhotoCapabilitiesCallback scoped_get_callback(
- base::Bind(&MockImageCaptureClient::DoOnGetPhotoCapabilities,
- image_capture_client_),
- media::BindToCurrentLoop(
- base::Bind(&MockImageCaptureClient::OnGetPhotoCapabilitiesFailure,
- image_capture_client_)));
-
- EXPECT_CALL(*image_capture_client_.get(), OnCorrectGetPhotoCapabilities())
- .Times(1);
-
- device->GetPhotoCapabilities(std::move(scoped_get_callback));
- WaitForCapturedFrame();
-
- auto* capabilities = image_capture_client_->capabilities();
- ASSERT_TRUE(capabilities);
-
- device->StopAndDeAllocate();
-}
-
}; // namespace media
« no previous file with comments | « media/capture/video/linux/video_capture_device_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698