Make resizing a window by snapping it left or right take into account the window's minimum width

Make resizing a window by snapping it left or right take into account the window's minimum width.
Previously the lack of consideration of the minimum width resulted in the window ending up partially offscreen when snapped to a smaller width than its minimum width

BUG=None
TEST=SnapSizerTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222402

[pkotwicz, 2013-09-08 02:28:54]

skuhne@, can you please take a look?

[Mr4D (OOO till 08-26), 2013-09-08 17:31:30]

lgtm with a few nits.

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
File ash/wm/workspace/snap_sizer.cc (right):

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
ash/wm/workspace/snap_sizer.cc:54: // ash::wm::CanSnapWindow() returns false
when a max size is specified.
This comment is oddly placed. Can you move it into the main functions
description (line 49)?

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
ash/wm/workspace/snap_sizer.cc:61: int width = std::max(1024, work_area.width()
/ 2);
The 1024 should probably be a constant.

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
ash/wm/workspace/snap_sizer.cc:96: ideal_width_list.push_back(minimum_width);
minimum_width might be 0.

[pkotwicz, 2013-09-09 02:22:45]

jamescook@ for OWNERS

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
File ash/wm/workspace/snap_sizer.cc (right):

https://codereview.chromium.org/23645009/diff/2001/ash/wm/workspace/snap_size...
ash/wm/workspace/snap_sizer.cc:96: ideal_width_list.push_back(minimum_width);
I now check if |minimum_width| == 0. Of note, it is impossible to get into a
situation where |ideal_width_list|.empty() and the |minimum_width| == 0 given
the current implementation of GetMaxWidth(), but that implementation could
change.

[James Cook, 2013-09-09 22:41:10]

LGTM

What is the current default size if you snap a window?  Half the screen?  It's
not particularly obvious from this code or the test.

[James Cook, 2013-09-09 23:03:00]

https://codereview.chromium.org/23645009/diff/20001/ash/wm/workspace/snap_siz...
File ash/wm/workspace/snap_sizer.cc (right):

https://codereview.chromium.org/23645009/diff/20001/ash/wm/workspace/snap_siz...
ash/wm/workspace/snap_sizer.cc:196: return GetTargetBoundsForSize(current %
usable_width_.size());
Also, if the loop above terminates, does this do:

current ==-1 => 18446744073709551615
% 5 == 0

Then cast to a size_t?  This appears to work, but only because -1 happens to be
represented by a number evenly divisible by 5?

[commit-bot: I haz the power, 2013-09-10 15:34:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/23645009/20001

[commit-bot: I haz the power, 2013-09-10 18:47:36]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-09-10 19:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/23645009/50001

[commit-bot: I haz the power, 2013-09-10 23:46:52]

Change committed as 222402