Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2364473006: [stubs] Extract ToInteger to CodeStubAssembler (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Extract ToInteger to CodeStubAssembler Moving ToInteger to CodeStubAssembler allows us to inline it in several builtins. In a follow-up commit, we'll add a TruncationMode argument to specify how -0.0 should be handled. BUG= Committed: https://crrev.com/84145a149bcfc028b26fa6c5000e647c26d54db5 Cr-Commit-Position: refs/heads/master@{#39671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -65 lines) Patch
M src/builtins/builtins-array.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +3 lines, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 3 months ago (2016-09-23 08:49:06 UTC) #4
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-23 09:10:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364473006/1
4 years, 3 months ago (2016-09-23 11:54:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 14:28:01 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 14:28:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84145a149bcfc028b26fa6c5000e647c26d54db5
Cr-Commit-Position: refs/heads/master@{#39671}

Powered by Google App Engine
This is Rietveld 408576698