Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2361363002: [stubs] Add TruncationMode argument to ToInteger (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add TruncationMode argument to ToInteger Passing kTruncateMinusZero truncates -0.0 to Smi 0, while kNoTruncation returns -0.0 as a heap number. BUG= Committed: https://crrev.com/693276a46af32467baaade8e7c0b5c50d0a7c1f6 Cr-Commit-Position: refs/heads/master@{#39710}

Patch Set 1 #

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -118 lines) Patch
M src/builtins/builtins-string.cc View 1 4 chunks +18 lines, -116 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
jgruber
4 years, 3 months ago (2016-09-23 09:07:16 UTC) #4
Igor Sheludko
Nice cleanup! lgtm
4 years, 2 months ago (2016-09-26 08:24:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361363002/20001
4 years, 2 months ago (2016-09-26 08:26:09 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 08:50:29 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 08:50:52 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/693276a46af32467baaade8e7c0b5c50d0a7c1f6
Cr-Commit-Position: refs/heads/master@{#39710}

Powered by Google App Engine
This is Rietveld 408576698