Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2364473003: [inspector] removed build flags for compilation warnings (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] removed build flags for compilation warnings All warnings were fixed. MSVS builds V8 with inspector without warnings. BUG=chromium:635948 R=jochen@chromium.org Committed: https://crrev.com/0defdc30e42c5ce89100a8e1ce916a6fea34c6f5 Cr-Commit-Position: refs/heads/master@{#39734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/v8.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kozy
Jochen, please take a look!
4 years, 3 months ago (2016-09-22 15:37:19 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-26 14:56:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364473003/1
4 years, 2 months ago (2016-09-26 15:05:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 15:52:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 15:53:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0defdc30e42c5ce89100a8e1ce916a6fea34c6f5
Cr-Commit-Position: refs/heads/master@{#39734}

Powered by Google App Engine
This is Rietveld 408576698