Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: src/v8.gyp

Issue 2364473003: [inspector] removed build flags for compilation warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index f09155b5bdb40b4b8fbf745cfe04d573e55d38a2..01bb968bda1bcd5ea2f28cc96b209f2116dd07d5 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -1748,15 +1748,6 @@
'inspector/inspector.gyp:inspector_injected_script',
'inspector/inspector.gyp:inspector_debugger_script',
],
- # TODO(dgozman): fix these warnings and enable them.
- 'msvs_disabled_warnings': [
- 4305, # Truncation from 'type1' to 'type2'.
- 4324, # Struct padded due to declspec(align).
- 4714, # Function marked forceinline not inlined.
- 4800, # Value forced to bool.
- ],
- 'cflags': [
- ],
}],
['OS=="win" and v8_enable_i18n_support==1', {
'dependencies': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698