ARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs

include/core/SkXfermode.h

Index: include/core/SkXfermode.h
diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h
index ef00f71b75ecb95bf4a900718efb79356e0a1b35..a4285d1103c6781760f2db26a9251fc34dd18188 100644
--- a/include/core/SkXfermode.h
+++ b/include/core/SkXfermode.h
@@ -271,9 +271,9 @@ protected:
         fProc = proc;
     }
 
-private:
     SkXfermodeProc  fProc;

[reed1, 2013/10/07 16:24:31]

I presume your subclasses need access to fProc. Is that read-only access? I hope
so, as we now *require* that xfermodes be immutable once created, so we can
share instances of them between threads.

Assuming it is read-only, can you just add a (protected) getter instead of
exposing the field?

[kevin.petit.not.used.account, 2013/10/07 17:18:51]

Done.

 
+private:
     typedef SkXfermode INHERITED;
 };