ARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs

include/core/SkXfermode.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkXfermode_DEFINED
@@ skipping 253 matching lines @@
 
 protected:
     SkProcXfermode(SkFlattenableReadBuffer&);
     virtual void flatten(SkFlattenableWriteBuffer&) const SK_OVERRIDE;
 
     // allow subclasses to update this after we unflatten
     void setProc(SkXfermodeProc proc) {
         fProc = proc;
     }
 
-private:
     SkXfermodeProc  fProc;

[reed1, 2013/10/07 16:24:31]

I presume your subclasses need access to fProc. Is that read-only access? I hope
so, as we now *require* that xfermodes be immutable once created, so we can
share instances of them between threads.

Assuming it is read-only, can you just add a (protected) getter instead of
exposing the field?

[kevin.petit.not.used.account, 2013/10/07 17:18:51]

Done.

 
+private:
     typedef SkXfermode INHERITED;
 };
 
 #endif