ARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs

include/core/SkXfermode.h

Index: include/core/SkXfermode.h
diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h
index ef00f71b75ecb95bf4a900718efb79356e0a1b35..6446cd5524c6b49da5235c9c5a2ff15afa87b33c 100644
--- a/include/core/SkXfermode.h
+++ b/include/core/SkXfermode.h
@@ -12,6 +12,7 @@
 
 #include "SkFlattenable.h"
 #include "SkColor.h"
+#include "SkXfermode_opts.h"

[djsollen, 2013/10/03 16:38:29]

we shouldn't have private headers exposed in our public includes.

 
 class GrContext;
 class GrEffectRef;
@@ -249,7 +250,9 @@ private:
 */
 class SkProcXfermode : public SkXfermode {
 public:
-    SkProcXfermode(SkXfermodeProc proc) : fProc(proc) {}
+    SkProcXfermode(SkXfermodeProc proc) : fProc(proc), fProcSIMD(NULL) {}
+    SkProcXfermode(SkXfermodeProc proc, SkXfermodeProcSIMD procSIMD) :
+        fProc(proc), fProcSIMD(procSIMD) {}
 
     // overrides from SkXfermode
     virtual void xfer32(SkPMColor dst[], const SkPMColor src[], int count,
@@ -267,12 +270,14 @@ protected:
     virtual void flatten(SkFlattenableWriteBuffer&) const SK_OVERRIDE;
 
     // allow subclasses to update this after we unflatten
-    void setProc(SkXfermodeProc proc) {
+    void setProcs(SkXfermodeProc proc, SkXfermodeProcSIMD procSIMD) {
         fProc = proc;
+        fProcSIMD = procSIMD;
     }
 
 private:
     SkXfermodeProc  fProc;
+    SkXfermodeProcSIMD  fProcSIMD;

[djsollen, 2013/10/03 16:38:29]

I don't think we should expose this here.  My initial reaction is if a custom
subclass really wants to include SIMD optimizations they should override the
entire xfer..() method and not use SkProcXferMode.

However, for the built-in SkProcXferModes that we support we could provide an
internal SIMD override.

 
     typedef SkXfermode INHERITED;
 };