ARM Skia NEON patches - 28 - Xfermode: SIMD modeprocs

include/core/SkXfermode.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkXfermode_DEFINED
 #define SkXfermode_DEFINED
 
 #include "SkFlattenable.h"
 #include "SkColor.h"
+#include "SkXfermode_opts.h"

[djsollen, 2013/10/03 16:38:29]

we shouldn't have private headers exposed in our public includes.

 
 class GrContext;
 class GrEffectRef;
 class GrTexture;
 class SkString;
 
 /** \class SkXfermode
 
     SkXfermode is the base class for objects that are called to implement custom
     "transfer-modes" in the drawing pipeline. The static function Create(Modes)
@@ skipping 217 matching lines @@
 
 ///////////////////////////////////////////////////////////////////////////////
 
 /** \class SkProcXfermode
 
     SkProcXfermode is a xfermode that applies the specified proc to its colors.
     This class is not exported to java.
 */
 class SkProcXfermode : public SkXfermode {
 public:
-    SkProcXfermode(SkXfermodeProc proc) : fProc(proc) {}
+    SkProcXfermode(SkXfermodeProc proc) : fProc(proc), fProcSIMD(NULL) {}
+    SkProcXfermode(SkXfermodeProc proc, SkXfermodeProcSIMD procSIMD) :
+        fProc(proc), fProcSIMD(procSIMD) {}
 
     // overrides from SkXfermode
     virtual void xfer32(SkPMColor dst[], const SkPMColor src[], int count,
                         const SkAlpha aa[]) const SK_OVERRIDE;
     virtual void xfer16(uint16_t dst[], const SkPMColor src[], int count,
                         const SkAlpha aa[]) const SK_OVERRIDE;
     virtual void xferA8(SkAlpha dst[], const SkPMColor src[], int count,
                         const SkAlpha aa[]) const SK_OVERRIDE;
 
     SK_DEVELOPER_TO_STRING()
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkProcXfermode)
 
 protected:
     SkProcXfermode(SkFlattenableReadBuffer&);
     virtual void flatten(SkFlattenableWriteBuffer&) const SK_OVERRIDE;
 
     // allow subclasses to update this after we unflatten
-    void setProc(SkXfermodeProc proc) {
+    void setProcs(SkXfermodeProc proc, SkXfermodeProcSIMD procSIMD) {
         fProc = proc;
+        fProcSIMD = procSIMD;
     }
 
 private:
     SkXfermodeProc  fProc;
+    SkXfermodeProcSIMD  fProcSIMD;

[djsollen, 2013/10/03 16:38:29]

I don't think we should expose this here.  My initial reaction is if a custom
subclass really wants to include SIMD optimizations they should override the
entire xfer..() method and not use SkProcXferMode.

However, for the built-in SkProcXferModes that we support we could provide an
internal SIMD override.

 
     typedef SkXfermode INHERITED;
 };
 
 #endif