Chromium Code Reviews| Index: chrome/browser/android/webapk/webapk_installer.h |
| diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h |
| index eb24f5b2ce428e14f5fb30f19b64f6a1de3fc09b..544760b380cf6258c901509ad46c75d547d22319 100644 |
| --- a/chrome/browser/android/webapk/webapk_installer.h |
| +++ b/chrome/browser/android/webapk/webapk_installer.h |
| @@ -38,6 +38,12 @@ class WebApkIconHasher; |
| // Java WebApkInstaller counterpart. |
| class WebApkInstaller : public net::URLFetcherDelegate { |
| public: |
| + enum TaskType { |
| + UNDEFINED, |
| + INSTALL, |
| + UPDATE, |
| + }; |
| + |
| // Called when the creation/updating of a WebAPK is finished or failed. |
| // Parameters: |
| // - whether the process succeeds. |
| @@ -109,12 +115,6 @@ class WebApkInstaller : public net::URLFetcherDelegate { |
| void OnSuccess(); |
| private: |
| - enum TaskType { |
| - UNDEFINED, |
| - INSTALL, |
| - UPDATE, |
| - }; |
| - |
| // Create the Java object. |
| void CreateJavaRef(); |
| @@ -149,6 +149,11 @@ class WebApkInstaller : public net::URLFetcherDelegate { |
| void OnGotWebApkDownloadUrl(const GURL& download_url, |
| const std::string& package_name); |
| + // Called once the sub directory to store the downloaded WebApk was |
|
pkotwicz
2016/09/26 21:05:49
WebApk -> WebAPK
Xi Han
2016/09/26 22:22:17
Done.
|
| + // created with permissions set properly or failed to create. |
|
pkotwicz
2016/09/26 21:04:25
Nit: "or failed to create." -> "or if creation fai
Xi Han
2016/09/26 22:22:17
Change to "or if creation failed".
|
| + void OnCreateSubDirAndSetPermissions(const GURL& download_url, |
| + const base::FilePath& file_path); |
| + |
| // Called once the WebAPK has been downloaded. Makes the downloaded WebAPK |
| // world readable and installs the WebAPK if the download was successful. |
| // |file_path| is the file path that the WebAPK was downloaded to. |