Download WebAPK into a WebAPK-specifc directory, and delete all cached ones.

chrome/browser/android/webapk/webapk_installer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_
 #define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_
 
 #include <jni.h>
 #include <memory>
 
@@ skipping 20 matching lines @@
 class WebApk;
 }
 
 class WebApkIconHasher;
 
 // Talks to Chrome WebAPK server and Google Play to generate a WebAPK on the
 // server, download it, and install it. The native WebApkInstaller owns the
 // Java WebApkInstaller counterpart.
 class WebApkInstaller : public net::URLFetcherDelegate {
  public:
+  enum TaskType {
+    UNDEFINED,
+    INSTALL,
+    UPDATE,
+  };
+
   // Called when the creation/updating of a WebAPK is finished or failed.
   // Parameters:
   // - whether the process succeeds.
   // - the package name of the WebAPK.
   using FinishCallback = base::Callback<void(bool, const std::string&)>;
 
   WebApkInstaller(const ShortcutInfo& shortcut_info,
                   const SkBitmap& shorcut_icon);
 
   ~WebApkInstaller() override;
@@ skipping 51 matching lines @@
   // could be started. The updating may still fail if true is returned.
   // |file_path| is the file path that the WebAPK was downloaded to.
   virtual bool StartUpdateUsingDownloadedWebApk(
       JNIEnv* env,
       const base::android::ScopedJavaLocalRef<jstring>& java_file_path);
 
   // Called when the request to install the WebAPK is sent to Google Play.
   void OnSuccess();
 
  private:
-  enum TaskType {
-    UNDEFINED,
-    INSTALL,
-    UPDATE,
-  };
-
   // Create the Java object.
   void CreateJavaRef();
 
   // net::URLFetcherDelegate:
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Downloads app icon in order to compute Murmur2 hash.
   void DownloadAppIconAndComputeMurmur2Hash();
 
   // Called with the computed Murmur2 hash for the app icon.
@@ skipping 14 matching lines @@
   // WebAPK.
   void SendRequest(std::unique_ptr<webapk::WebApk> request_proto,
                    net::URLFetcher::RequestType request_type,
                    const GURL& server_url);
 
   // Called with the URL of generated WebAPK and the package name that the
   // WebAPK should be installed at.
   void OnGotWebApkDownloadUrl(const GURL& download_url,
                               const std::string& package_name);
 
+  // Called once the sub directory to store the downloaded WebApk was

[pkotwicz, 2016/09/26 21:05:49]

WebApk -> WebAPK

[Xi Han, 2016/09/26 22:22:17]

Done.

+  // created with permissions set properly or failed to create.

[pkotwicz, 2016/09/26 21:04:25]

Nit: "or failed to create." -> "or if creation fails."

[Xi Han, 2016/09/26 22:22:17]

Change to "or if creation failed".

+  void OnCreateSubDirAndSetPermissions(const GURL& download_url,
+                                       const base::FilePath& file_path);
+
   // Called once the WebAPK has been downloaded. Makes the downloaded WebAPK
   // world readable and installs the WebAPK if the download was successful.
   // |file_path| is the file path that the WebAPK was downloaded to.
   void OnWebApkDownloaded(const base::FilePath& file_path,
                           FileDownloader::Result result);
 
   // Called once the downloaded WebAPK has been made world readable. Installs
   // the WebAPK.
   // |file_path| is the file path that the WebAPK was downloaded to.
   // |change_permission_success| is whether the WebAPK could be made world
@@ skipping 61 matching lines @@
   // Points to the Java Object.
   base::android::ScopedJavaGlobalRef<jobject> java_ref_;
 
   // Used to get |weak_ptr_|.
   base::WeakPtrFactory<WebApkInstaller> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebApkInstaller);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_