Replace deprecated ScopedVector<T> in arc::FakeAppInstance

Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
Committed: https://crrev.com/55b2ff22878b069b9d7dd5e607cf9616ad709fdd
Cr-Commit-Position: refs/heads/master@{#420758}

[Ben Chan, 2016-09-23 16:49:51]

The CQ bit was checked by benchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 16:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Chan, 2016-09-23 17:00:59]

Description was changed from

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
==========

to

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
==========

[Ben Chan, 2016-09-23 17:00:59]

benchan@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Ben Chan, 2016-09-23 17:05:28]

benchan@chromium.org changed reviewers:
- lhchavez@chromium.org

[Ben Chan, 2016-09-23 17:05:57]

On 2016/09/23 17:01:50, Ben Chan wrote:

sorry, not ready for review yet as there are more call sites to update

[Ben Chan, 2016-09-23 17:12:22]

The CQ bit was checked by benchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:12:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Chan, 2016-09-23 17:40:23]

Patchset #2 (id:10001) has been deleted

[Ben Chan, 2016-09-23 17:40:29]

Patchset #1 (id:1) has been deleted

[Ben Chan, 2016-09-23 17:40:36]

The CQ bit was checked by benchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:05:52]

Dry run: This issue passed the CQ dry run.

[Ben Chan, 2016-09-23 19:58:07]

On 2016/09/23 17:05:57, Ben Chan wrote:
> On 2016/09/23 17:01:50, Ben Chan wrote:
> 
> sorry, not ready for review yet as there are more call sites to update

ready for review

[Ben Chan, 2016-09-23 19:59:15]

benchan@chromium.org changed reviewers:
+ lhchavez@chromium.org, stevenjb@chromium.org

[Luis Héctor Chávez, 2016-09-23 20:03:00]

Thanks!

I think I got all the IWYU, but can you run `git cl lint` just in case I missed
one?

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_context_menu_unittest.cc (right):

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_context_menu_unittest.cc:7: #include
<unordered_set>
nit: #include <utility>

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:10: #include <string>
nit: #include <utility>

[Ben Chan, 2016-09-23 21:01:01]

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_context_menu_unittest.cc (right):

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_context_menu_unittest.cc:7: #include
<unordered_set>
On 2016/09/23 20:03:00, Luis Héctor Chávez wrote:
> nit: #include <utility>

here's what I got from `git cl lint` and `cpplint.py` (from latest depot_tools
ff84560e). Did your cpplint run report IWYU error?  One possibility is that your
chrome HEAD is slightly different than mine. Mine is at the latest 9f70a54d7

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:848: 
Is this a non-const reference? If so, make const or use a pointer: std::string&
window_app_id  [runtime/references] [2]
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1228:
 Lines should be <= 80 characters long  [whitespace/line_length] [2]
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1943:
 Missing username in TODO; it should look like "// TODO(my_username): Stuff." 
[readability/todo] [2]
Done processing
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
Done processing components/arc/test/fake_app_instance.cc
Done processing components/arc/test/fake_app_instance.h

I can clean up the above lint errors in a follow-up CL, which seems unrelated to
the ScopedVector changes.

[Luis Héctor Chávez, 2016-09-23 21:37:06]

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_context_menu_unittest.cc (right):

https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_context_menu_unittest.cc:7: #include
<unordered_set>
On 2016/09/23 21:01:00, Ben Chan wrote:
> On 2016/09/23 20:03:00, Luis Héctor Chávez wrote:
> > nit: #include <utility>
> 
> here's what I got from `git cl lint` and `cpplint.py` (from latest depot_tools
> ff84560e). Did your cpplint run report IWYU error?  One possibility is that
your
> chrome HEAD is slightly different than mine. Mine is at the latest 9f70a54d7
> 
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:848: 
> Is this a non-const reference? If so, make const or use a pointer:
std::string&
> window_app_id  [runtime/references] [2]
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1228:
>  Lines should be <= 80 characters long  [whitespace/line_length] [2]
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1943:
>  Missing username in TODO; it should look like "// TODO(my_username): Stuff." 
> [readability/todo] [2]
> Done processing
> chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
> Done processing components/arc/test/fake_app_instance.cc
> Done processing components/arc/test/fake_app_instance.h
> 
> I can clean up the above lint errors in a follow-up CL, which seems unrelated
to
> the ScopedVector changes.

I didn't run git cl lint locally, just did the normal review. The change that
should have flagged the <utility> IWYU is 2d1b6dae5acc5, which you definitely
have :( I'll follow up that one separately.

Not cleaning up the unrelated lint errors in this CL SGTM.

[Ben Chan, 2016-09-23 21:55:09]

On 2016/09/23 21:37:06, Luis Héctor Chávez wrote:
>
https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
> File chrome/browser/ui/app_list/app_context_menu_unittest.cc (right):
> 
>
https://codereview.chromium.org/2364113002/diff/30001/chrome/browser/ui/app_l...
> chrome/browser/ui/app_list/app_context_menu_unittest.cc:7: #include
> <unordered_set>
> On 2016/09/23 21:01:00, Ben Chan wrote:
> > On 2016/09/23 20:03:00, Luis Héctor Chávez wrote:
> > > nit: #include <utility>
> > 
> > here's what I got from `git cl lint` and `cpplint.py` (from latest
depot_tools
> > ff84560e). Did your cpplint run report IWYU error?  One possibility is that
> your
> > chrome HEAD is slightly different than mine. Mine is at the latest 9f70a54d7
> > 
> >
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:848: 
> > Is this a non-const reference? If so, make const or use a pointer:
> std::string&
> > window_app_id  [runtime/references] [2]
> >
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1228:
> >  Lines should be <= 80 characters long  [whitespace/line_length] [2]
> >
>
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1943:
> >  Missing username in TODO; it should look like "// TODO(my_username):
Stuff." 
> > [readability/todo] [2]
> > Done processing
> > chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
> > Done processing components/arc/test/fake_app_instance.cc
> > Done processing components/arc/test/fake_app_instance.h
> > 
> > I can clean up the above lint errors in a follow-up CL, which seems
unrelated
> to
> > the ScopedVector changes.
> 
> I didn't run git cl lint locally, just did the normal review. The change that
> should have flagged the <utility> IWYU is 2d1b6dae5acc5, which you definitely
> have :( I'll follow up that one separately.
> 
> Not cleaning up the unrelated lint errors in this CL SGTM.

I cleaned up the header inclusion a bit. Inclusion of <utility> is only needed
for std::move, std::make_pair, etc:
- fake_app_instance.h doesn't need to include <utility>, while
fake_app_instance.cc does as it uses std::move()
- app_context_menu_unittest.cc, arc_app_unittest.cc should include <memory> as
it uses std::unique_ptr for code unrelated to this change

PTAL

[Ben Chan, 2016-09-23 21:56:07]

The CQ bit was checked by benchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:56:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-09-23 21:57:08]

Thanks!

lgtm

[Ben Chan, 2016-09-23 22:12:34]

On 2016/09/23 21:57:08, Luis Héctor Chávez wrote:
> Thanks!
> 
> lgtm

Thanks.

stevenjb@, could you review and lgtm chrome/browser/ui/*?

[commit-bot: I haz the power, 2016-09-23 22:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:19:06]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[stevenjb, 2016-09-23 22:29:34]

lgtm

[Ben Chan, 2016-09-23 22:34:13]

The CQ bit was checked by benchan@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:35:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:48:56]

Description was changed from

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
==========

to

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
==========

[commit-bot: I haz the power, 2016-09-23 22:48:57]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-09-23 22:50:58]

Description was changed from

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289
==========

to

==========
Replace deprecated ScopedVector<T> in arc::FakeAppInstance

This CL changes arc::FakeAppInstance to use vector<unique_ptr<T>> instead of
the deprecated ScopedVector<T>.

BUG=554289

Committed: https://crrev.com/55b2ff22878b069b9d7dd5e607cf9616ad709fdd
Cr-Commit-Position: refs/heads/master@{#420758}
==========

[commit-bot: I haz the power, 2016-09-23 22:51:00]

Patchset 2 (id:??) landed as
https://crrev.com/55b2ff22878b069b9d7dd5e607cf9616ad709fdd
Cr-Commit-Position: refs/heads/master@{#420758}