Replace deprecated ScopedVector<T> in arc::FakeAppInstance

chrome/browser/ui/app_list/app_context_menu_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <string>
 #include <unordered_set>

[Luis Héctor Chávez, 2016/09/23 20:03:00]

nit: #include <utility>

[Ben Chan, 2016/09/23 21:01:00]

here's what I got from `git cl lint` and `cpplint.py` (from latest depot_tools
ff84560e). Did your cpplint run report IWYU error?  One possibility is that your
chrome HEAD is slightly different than mine. Mine is at the latest 9f70a54d7

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:848: 
Is this a non-const reference? If so, make const or use a pointer: std::string&
window_app_id  [runtime/references] [2]
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1228:
 Lines should be <= 80 characters long  [whitespace/line_length] [2]
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:1943:
 Missing username in TODO; it should look like "// TODO(my_username): Stuff." 
[readability/todo] [2]
Done processing
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
Done processing components/arc/test/fake_app_instance.cc
Done processing components/arc/test/fake_app_instance.h

I can clean up the above lint errors in a follow-up CL, which seems unrelated to
the ScopedVector changes.

[Luis Héctor Chávez, 2016/09/23 21:37:06]

I didn't run git cl lint locally, just did the normal review. The change that
should have flagged the <utility> IWYU is 2d1b6dae5acc5, which you definitely
have :( I'll follow up that one separately.

Not cleaning up the unrelated lint errors in this CL SGTM.

 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/menu_manager_factory.h"
 #include "chrome/browser/ui/app_list/app_context_menu_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_test_util.h"
@@ skipping 352 matching lines @@
   EXPECT_FALSE(menu->IsItemCheckedAt(2));
   EXPECT_EQ(app_list::AppContextMenu::SHOW_APP_INFO, menu->GetCommandIdAt(3));
   EXPECT_TRUE(menu->IsEnabledAt(3));
   EXPECT_FALSE(menu->IsItemCheckedAt(3));
 
   // Test activate request.
   EXPECT_EQ(0u, arc_test.app_instance()->launch_requests().size());
 
   menu->ActivatedAt(0);
 
-  const ScopedVector<arc::FakeAppInstance::Request>& launch_requests =
-      arc_test.app_instance()->launch_requests();
+  const std::vector<std::unique_ptr<arc::FakeAppInstance::Request>>&
+      launch_requests = arc_test.app_instance()->launch_requests();
   ASSERT_EQ(1u, launch_requests.size());
   EXPECT_TRUE(launch_requests[0]->IsForApp(app_info));
 
   controller()->SetAppOpen(app_id, true);
   // It is not expected that menu model is unchanged on GetContextMenuModel. Arc
   // app menu requires model to be recalculated.
   menu = item.GetContextMenuModel();
   ASSERT_EQ(2, menu->GetItemCount());
   EXPECT_EQ(app_list::AppContextMenu::TOGGLE_PIN, menu->GetCommandIdAt(0));
   EXPECT_TRUE(menu->IsEnabledAt(0));
@@ skipping 74 matching lines @@
     EXPECT_EQ(-1, menu->GetCommandIdAt(3));  // separator
     EXPECT_EQ(app_list::AppContextMenu::UNINSTALL, menu->GetCommandIdAt(4));
     EXPECT_TRUE(menu->IsEnabledAt(4));
     EXPECT_FALSE(menu->IsItemCheckedAt(4));
     EXPECT_EQ(app_list::AppContextMenu::SHOW_APP_INFO, menu->GetCommandIdAt(5));
     EXPECT_TRUE(menu->IsEnabledAt(5));
     EXPECT_FALSE(menu->IsItemCheckedAt(5));
   }
 }
 #endif