Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2364073002: Reland of HTMLImageElement: do not use fallback content for ImageDocument (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of HTMLImageElement: do not use fallback content for ImageDocument (patchset #1 id:1 of https://codereview.chromium.org/2365523003/ ) Reason for revert: As per comment #8, this CL wasn't the cause of bot failures. https://codereview.chromium.org/2365523003/#msg8 Original issue's description: > Revert of HTMLImageElement: do not use fallback content for ImageDocument (patchset #2 id:20001 of https://codereview.chromium.org/2343613002/ ) > > Reason for revert: > Speculatively reverting to fix broken layout tests on Windows (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10, https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7) > > Tests are > > fast/backgrounds/border-radius-split-background-image.html > fast/backgrounds/border-radius-split-background.html > fast/borders/border-styles-split.html > paint/invalidation/background-resize-height.html > > Original issue's description: > > HTMLImageElement: do not use fallback content for ImageDocument > > > > After https://codereview.chromium.org/1879793003, > > ImageLoader::hasPendingActivity() became false for ImageDocument and thus > > HTMLImageElement::selectSourceURL() didn't consider the image as still loading > > during load (|imageStillLoading| became false). > > This caused ImageDocument not to be displayed progressively. > > > > This CL makes HTMLImageElement to use primary content for ImageDocument. > > This causes ImageDocument not to be replaced with fallback content, but I > > expect that is more acceptable than images not displayed progressively. > > > > BUG=632495 > > > > Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76 > > Cr-Commit-Position: refs/heads/master@{#420432} > > TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,hiroshige@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=632495 > > Committed: https://crrev.com/70e44d10fc52150a6af5a7de760cb9181587fbb4 > Cr-Commit-Position: refs/heads/master@{#420499} TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,gcasto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632495 Committed: https://crrev.com/cc960a01f9c5d39ead364b1cb929c999323d3dc6 Cr-Commit-Position: refs/heads/master@{#420616}

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
hiroshige
Created Reland of HTMLImageElement: do not use fallback content for ImageDocument
4 years, 3 months ago (2016-09-23 15:44:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364073002/1
4 years, 3 months ago (2016-09-23 15:46:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 15:48:29 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 15:50:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc960a01f9c5d39ead364b1cb929c999323d3dc6
Cr-Commit-Position: refs/heads/master@{#420616}

Powered by Google App Engine
This is Rietveld 408576698