HTMLImageElement: do not use fallback content for ImageDocument

HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495
Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
Cr-Commit-Position: refs/heads/master@{#420432}

[hiroshige, 2016-09-15 08:15:43]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 08:15:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 09:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:27:14]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-09-15 10:03:09]

Description was changed from

==========
Always show ImageDocument even when hasPendingActivity() is false

BUG=
==========

to

==========
Always show ImageDocument even when hasPendingActivity() is false

BUG=632495
==========

[hiroshige, 2016-09-15 10:08:45]

Description was changed from

==========
Always show ImageDocument even when hasPendingActivity() is false

BUG=632495
==========

to

==========
HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495
==========

[hiroshige, 2016-09-15 10:09:17]

hiroshige@chromium.org changed reviewers:
+ ellyjones@chromium.org, japhet@chromium.org, yhirano@chromium.org

[hiroshige, 2016-09-15 10:09:18]

PTAL.

[hiroshige, 2016-09-15 10:09:41]

On 2016/09/15 10:09:18, hiroshige wrote:
> PTAL.

I'm planning to merge the fix to stable.

[Elly Fong-Jones, 2016-09-15 10:18:43]

On 2016/09/15 10:09:18, hiroshige wrote:
> PTAL.

This change will break disabling images, won't it? That is, if you forbid a site
from loading images, instead of getting the "there was an image here" picture
you will get a blank space, and therefore no way to interact with the <img>
element?

[hiroshige, 2016-09-15 10:38:00]

On 2016/09/15 10:18:43, Elly Jones wrote:
> On 2016/09/15 10:09:18, hiroshige wrote:
> > PTAL.
> 
> This change will break disabling images, won't it? That is, if you forbid a
site
> from loading images, instead of getting the "there was an image here" picture
> you will get a blank space, and therefore no way to interact with the <img>
> element?

Er, probably. I'll add a test and update the code to keep the behavior with
disabling images.

[hiroshige, 2016-09-21 07:36:54]

> if you forbid a site
> from loading images, instead of getting the "there was an image here" picture
> you will get a blank space

This CL does not affect images loaded via <img> tags (because |imageIsDocument|
is always false for non-ImageDocument) and thus broken image icons are shown for
<img> tags with this CL when images are disabled.

When we open an image as the main resource (i.e. ImageDocument) and images are
disabled (via chrome://settings/content), then we get a blank page (no "broken
image"), at least since M-52 (so this CL doesn't cause regression).

[Elly Fong-Jones, 2016-09-21 10:44:29]

lgtm

[Nate Chapin, 2016-09-21 19:14:32]

lgtm

[hiroshige, 2016-09-22 18:38:22]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:38:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:53:07]

Description was changed from

==========
HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495
==========

to

==========
HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495
==========

[commit-bot: I haz the power, 2016-09-22 19:53:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 19:59:53]

Description was changed from

==========
HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495
==========

to

==========
HTMLImageElement: do not use fallback content for ImageDocument

After https://codereview.chromium.org/1879793003,
ImageLoader::hasPendingActivity() became false for ImageDocument and thus
HTMLImageElement::selectSourceURL() didn't consider the image as still loading
during load (|imageStillLoading| became false).
This caused ImageDocument not to be displayed progressively.

This CL makes HTMLImageElement to use primary content for ImageDocument.
This causes ImageDocument not to be replaced with fallback content, but I
expect that is more acceptable than images not displayed progressively.

BUG=632495

Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
Cr-Commit-Position: refs/heads/master@{#420432}
==========

[commit-bot: I haz the power, 2016-09-22 19:59:54]

Patchset 2 (id:??) landed as
https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
Cr-Commit-Position: refs/heads/master@{#420432}

[Garrett Casto, 2016-09-22 23:26:11]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2365523003/ by gcasto@chromium.org.

The reason for reverting is: Speculatively reverting to fix broken layout tests
on Windows
(https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10,
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7)

Tests are 

fast/backgrounds/border-radius-split-background-image.html 
fast/backgrounds/border-radius-split-background.html
fast/borders/border-styles-split.html
paint/invalidation/background-resize-height.html .