ValueSerializer: Handle JS_SPECIAL_API_OBJECT_TYPE.

ValueSerializer: Handle JS_SPECIAL_API_OBJECT_TYPE.

Some DOM objects, like FileList, have indexed property handlers, and become
JS_SPECIAL_API_OBJECT_TYPE.

BUG=chromium:148757
Committed: https://crrev.com/b171109334c59aeac4a17b2e7d38cbd80bac4923
Cr-Commit-Position: refs/heads/master@{#39686}

[jbroman, 2016-09-23 15:51:23]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 15:51:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-23 15:53:23]

jbroman@chromium.org changed reviewers:
+ cbruni@chromium.org, jkummerow@chromium.org

[jbroman, 2016-09-23 15:53:24]

As I work through the DOM objects on the Blink side, I've noticed that FileList
is a JS_SPECIAL_API_OBJECT_TYPE, so that also needs to be delegated.

[commit-bot: I haz the power, 2016-09-23 16:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:19:21]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-09-23 17:20:30]

LGTM with nit.

https://codereview.chromium.org/2364053003/diff/1/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2364053003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:370: DCHECK(js_object->GetInternalFieldCount());
nit: {} please

Or even better:

DCHECK_IMPLIES(instance_type == JS_SPECIAL_API_OBJECT_TYPE,
               js_object->GetInternalFieldCount());

Or even better:

case JS_SPECIAL_API_OBJECT_TYPE:
  return WriteHostObject(Handle<JSObject>::cast(receiver));

[jbroman, 2016-09-23 17:50:35]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-09-23 17:50:36]

https://codereview.chromium.org/2364053003/diff/1/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2364053003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:370: DCHECK(js_object->GetInternalFieldCount());
On 2016/09/23 at 17:20:30, Jakob Kummerow wrote:
> nit: {} please

Urgh. I've been writing Blink CLs mostly for the last week or two. Sorry.

> Or even better:
> 
> DCHECK_IMPLIES(instance_type == JS_SPECIAL_API_OBJECT_TYPE,
>                js_object->GetInternalFieldCount());

Oh, v8 still has DCHECK_IMPLIES? Neat. It was removed from Chromium.

> Or even better:
> 
> case JS_SPECIAL_API_OBJECT_TYPE:
>   return WriteHostObject(Handle<JSObject>::cast(receiver));

Done.

[jbroman, 2016-09-23 17:50:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2364053003/#ps20001
(title: "jkummerow comments")

[commit-bot: I haz the power, 2016-09-23 17:50:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:19:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 18:19:51]

Description was changed from

==========
ValueSerializer: Handle JS_SPECIAL_API_OBJECT_TYPE.

Some DOM objects, like FileList, have indexed property handlers, and become
JS_SPECIAL_API_OBJECT_TYPE.

BUG=chromium:148757
==========

to

==========
ValueSerializer: Handle JS_SPECIAL_API_OBJECT_TYPE.

Some DOM objects, like FileList, have indexed property handlers, and become
JS_SPECIAL_API_OBJECT_TYPE.

BUG=chromium:148757

Committed: https://crrev.com/b171109334c59aeac4a17b2e7d38cbd80bac4923
Cr-Commit-Position: refs/heads/master@{#39686}
==========

[commit-bot: I haz the power, 2016-09-23 18:19:52]

Patchset 2 (id:??) landed as
https://crrev.com/b171109334c59aeac4a17b2e7d38cbd80bac4923
Cr-Commit-Position: refs/heads/master@{#39686}