ValueSerializer: Handle JS_SPECIAL_API_OBJECT_TYPE.

src/value-serializer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/value-serializer.h"
 
 #include <type_traits>
 
 #include "src/base/logging.h"
 #include "src/conversions.h"
@@ skipping 331 matching lines @@
     WriteVarint(id - 1);
     return Just(true);
   }
 
   // Otherwise, allocate an ID for it.
   uint32_t id = next_id_++;
   *id_map_entry = id + 1;
 
   // Eliminate callable and exotic objects, which should not be serialized.
   InstanceType instance_type = receiver->map()->instance_type();
-  if (receiver->IsCallable() || instance_type <= LAST_SPECIAL_RECEIVER_TYPE) {
+  if (receiver->IsCallable() || (instance_type <= LAST_SPECIAL_RECEIVER_TYPE &&
+                                 instance_type != JS_SPECIAL_API_OBJECT_TYPE)) {
     ThrowDataCloneError(MessageTemplate::kDataCloneError, receiver);
     return Nothing<bool>();
   }
 
   // If we are at the end of the stack, abort. This function may recurse.
   STACK_CHECK(isolate_, Nothing<bool>());
 
   HandleScope scope(isolate_);
   switch (instance_type) {
     case JS_ARRAY_TYPE:
       return WriteJSArray(Handle<JSArray>::cast(receiver));
     case JS_OBJECT_TYPE:
-    case JS_API_OBJECT_TYPE: {
+    case JS_API_OBJECT_TYPE:
+    case JS_SPECIAL_API_OBJECT_TYPE: {
       Handle<JSObject> js_object = Handle<JSObject>::cast(receiver);
+      if (instance_type == JS_SPECIAL_API_OBJECT_TYPE)
+        DCHECK(js_object->GetInternalFieldCount());

[Jakob Kummerow, 2016/09/23 17:20:30]

nit: {} please

Or even better:

DCHECK_IMPLIES(instance_type == JS_SPECIAL_API_OBJECT_TYPE,
               js_object->GetInternalFieldCount());

Or even better:

case JS_SPECIAL_API_OBJECT_TYPE:
  return WriteHostObject(Handle<JSObject>::cast(receiver));

[jbroman, 2016/09/23 17:50:36]

Urgh. I've been writing Blink CLs mostly for the last week or two. Sorry.
Oh, v8 still has DCHECK_IMPLIES? Neat. It was removed from Chromium.
Done.

       return js_object->GetInternalFieldCount() ? WriteHostObject(js_object)
                                                 : WriteJSObject(js_object);
     }
     case JS_DATE_TYPE:
       WriteJSDate(JSDate::cast(*receiver));
       return Just(true);
     case JS_VALUE_TYPE:
       return WriteJSValue(Handle<JSValue>::cast(receiver));
     case JS_REGEXP_TYPE:
       WriteJSRegExp(JSRegExp::cast(*receiver));
@@ skipping 1332 matching lines @@
   if (stack.size() != 1) {
     isolate_->Throw(*isolate_->factory()->NewError(
         MessageTemplate::kDataCloneDeserializationError));
     return MaybeHandle<Object>();
   }
   return scope.CloseAndEscape(stack[0]);
 }
 
 }  // namespace internal
 }  // namespace v8