Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2364033002: customtabs: Enable first contentful reporting. (Closed)

Created:
4 years, 3 months ago by Benoit L
Modified:
4 years, 3 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Enable first contentful paint reporting. This removes the code to selectively enable reporting, and enables the reporting. It was blocked by crbug.com/630303, which is now fixed. BUG=630303 Committed: https://crrev.com/0dffe41ce3f2e3e30f25f44a1055c0da995e8be1 Cr-Commit-Position: refs/heads/master@{#420624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benoit L
4 years, 3 months ago (2016-09-23 14:58:56 UTC) #3
Yusuf
lgtm
4 years, 3 months ago (2016-09-23 15:36:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364033002/1
4 years, 3 months ago (2016-09-23 15:38:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 16:31:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 16:35:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dffe41ce3f2e3e30f25f44a1055c0da995e8be1
Cr-Commit-Position: refs/heads/master@{#420624}

Powered by Google App Engine
This is Rietveld 408576698