Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 2364033002: customtabs: Enable first contentful reporting. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
index 89c0ea9ac3dfc4f028f91d33206766557808bb28..f2f39fb49b0eba90b2c5c08507bc2bd95bcd8cab 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
@@ -105,8 +105,6 @@ public class CustomTabsConnection {
private final AtomicBoolean mWarmupHasBeenCalled = new AtomicBoolean();
private final AtomicBoolean mWarmupHasBeenFinished = new AtomicBoolean();
private ExternalPrerenderHandler mExternalPrerenderHandler;
- // TODO(lizeb): Remove once crbug.com/630303 is fixed.
- private boolean mPageLoadMetricsEnabled;
/**
* <strong>DO NOT CALL</strong>
@@ -562,12 +560,6 @@ public class CustomTabsConnection {
return true;
}
- // TODO(lizeb): Remove once crbug.com/630303 is fixed.
- @VisibleForTesting
- void enablePageLoadMetricsCallbacks() {
- mPageLoadMetricsEnabled = true;
- }
-
/**
* Notifies the application of a page load metric.
*
@@ -580,7 +572,6 @@ public class CustomTabsConnection {
*/
boolean notifyPageLoadMetric(CustomTabsSessionToken session, String metricName, long offsetMs) {
CustomTabsCallback callback = mClientManager.getCallbackForSession(session);
- if (!mPageLoadMetricsEnabled) return false;
if (callback == null) return false;
Bundle args = new Bundle();
args.putLong(metricName, offsetMs);
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698