Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2363993003: Revert of Handling new frames and frame navigations with find-in-page during a find session. (Closed)

Created:
4 years, 3 months ago by Garrett Casto
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Handling new frames and frame navigations with find-in-page during a find session. (patchset #2 id:120001 of https://codereview.chromium.org/2236403004/ ) Reason for revert: This seems to be failing pretty consistently on some bots (e.g. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29) Original issue's description: > Handling new frames and frame navigations with find-in-page during a find session. > > This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. > > Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). > > Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view > > BUG=2220, 621660 > > Committed: https://crrev.com/ec9c7f30eb10ab3fc9ab6707f7b736446ab89aa1 > Cr-Commit-Position: refs/heads/master@{#420715} TBR=dcheng@chromium.org,pkasting@chromium.org,kenrb@chromium.org,paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=2220, 621660 Committed: https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6 Cr-Commit-Position: refs/heads/master@{#420774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -172 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/find_request_manager.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/find_request_manager.cc View 6 chunks +10 lines, -27 lines 0 comments Download
M content/browser/find_request_manager_browsertest.cc View 3 chunks +3 lines, -119 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 4 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFindOptions.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Garrett Casto
Created Revert of Handling new frames and frame navigations with find-in-page during a find session.
4 years, 3 months ago (2016-09-23 23:14:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363993003/1
4 years, 3 months ago (2016-09-23 23:15:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 23:16:26 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:19:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab0f2e9bc64a1caf21877b36972a30212c685e6
Cr-Commit-Position: refs/heads/master@{#420774}

Powered by Google App Engine
This is Rietveld 408576698