third_party/WebKit/Source/web/TextFinder.h - Issue 2363993003: Revert of Handling new frames and frame navigations with find-in-page during a find session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/TextFinder.h

Issue 2363993003: Revert of Handling new frames and frame navigations with find-in-page during a find session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/TextFinder.h

diff --git a/third_party/WebKit/Source/web/TextFinder.h b/third_party/WebKit/Source/web/TextFinder.h

index 2cb58f71415aba53022f4ff89f7d41f759706d80..c670aaf331c2ceea637958ec0173a54baab0020a 100644

--- a/third_party/WebKit/Source/web/TextFinder.h

+++ b/third_party/WebKit/Source/web/TextFinder.h

@@ -167,7 +167,7 @@

// It is not necessary if the frame is invisible, for example, or if this

// is a repeat search that already returned nothing last time the same prefix

// was searched.

- bool shouldScopeMatches(const WTF::String& searchText, const WebFindOptions&);

+ bool shouldScopeMatches(const WTF::String& searchText);

// Removes the current frame from the global scoping effort and triggers any

// updates if appropriate. This method does not mark the scoping operation

« no previous file with comments | « content/common/frame_messages.h ('k') | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »