Fix parsing of minimum values

Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557
Committed: https://crrev.com/54a7c25c0044c02449ee9366c9323ca1d2461b29
Cr-Commit-Position: refs/heads/master@{#423595}

[rwlbuis, 2016-10-06 12:38:49]

Description was changed from

==========
sign WIP

BUG=
==========

to

==========
sign WIP

BUG=490511
==========

[rwlbuis, 2016-10-06 12:54:00]

Description was changed from

==========
sign WIP

BUG=490511
==========

to

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=490511
==========

[rwlbuis, 2016-10-06 12:54:17]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-10-06 12:54:17]

PTAL.

[tkent, 2016-10-06 14:36:41]

You'll fix tabIndex-related failures in reflection-*.html tests, and this is a
preparation, right?

> BUG=490511

Pleas file a new bug for a specific wrong behavior.

[tkent, 2016-10-06 14:37:42]

https://codereview.chromium.org/2363823004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp (left):

https://codereview.chromium.org/2363823004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp:163: // Step 3
Adding a comment why the implementation is different from
https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers would
be helpful.

[rwlbuis, 2016-10-06 14:39:23]

On 2016/10/06 14:36:41, tkent wrote:
> You'll fix tabIndex-related failures in reflection-*.html tests, and this is a
> preparation, right?

Yes.

> > BUG=490511
> 
> Pleas file a new bug for a specific wrong behavior.

Will do.

[rwlbuis, 2016-10-06 15:06:54]

Description was changed from

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=490511
==========

to

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557
==========

[rwlbuis, 2016-10-06 15:10:44]

https://codereview.chromium.org/2363823004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp (left):

https://codereview.chromium.org/2363823004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp:163: // Step 3
On 2016/10/06 14:37:42, tkent wrote:
> Adding a comment why the implementation is different from
> https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
would
> be helpful.

Done.

[rwlbuis, 2016-10-06 15:11:12]

> > Pleas file a new bug for a specific wrong behavior.
> 
> Will do.

I added crbug.com/653557 for this.

[tkent, 2016-10-06 15:40:29]

lgtm

[rwlbuis, 2016-10-06 16:59:41]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-10-06 17:00:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:30:39]

Description was changed from

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557
==========

to

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557
==========

[commit-bot: I haz the power, 2016-10-06 18:30:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 18:34:22]

Description was changed from

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557
==========

to

==========
Fix parsing of minimum values

When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.

To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.

BUG=653557

Committed: https://crrev.com/54a7c25c0044c02449ee9366c9323ca1d2461b29
Cr-Commit-Position: refs/heads/master@{#423595}
==========

[commit-bot: I haz the power, 2016-10-06 18:34:23]

Patchset 3 (id:??) landed as
https://crrev.com/54a7c25c0044c02449ee9366c9323ca1d2461b29
Cr-Commit-Position: refs/heads/master@{#423595}