Fix parsing of minimum values

third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 142 matching lines @@
 
   bool valid = false;
   double value = string.toDouble(&valid);
   return checkDoubleValue(value, valid, fallbackValue);
 }
 
 template <typename CharacterType>
 static bool parseHTMLIntegerInternal(const CharacterType* position,
                                      const CharacterType* end,
                                      int& value) {
-  // Step 3

[tkent, 2016/10/06 14:37:42]

Adding a comment why the implementation is different from
https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers would
be helpful.

[rwlbuis, 2016/10/06 15:10:44]

Done.

-  int sign = 1;
-
   // Step 4
   while (position < end) {
     if (!isHTMLSpace<CharacterType>(*position))
       break;
     ++position;
   }
 
   // Step 5
   if (position == end)
     return false;
   ASSERT(position < end);
 
   // Step 6
+  StringBuilder digits;
   if (*position == '-') {
-    sign = -1;
+    digits.append('-');
     ++position;
   } else if (*position == '+')
     ++position;
   if (position == end)
     return false;
   ASSERT(position < end);
 
   // Step 7
   if (!isASCIIDigit(*position))
     return false;
 
   // Step 8
-  StringBuilder digits;
   while (position < end) {
     if (!isASCIIDigit(*position))
       break;
     digits.append(*position++);
   }
 
   // Step 9
   bool ok;
   if (digits.is8Bit())
-    value = sign *
-            charactersToIntStrict(digits.characters8(), digits.length(), &ok);
+    value = charactersToIntStrict(digits.characters8(), digits.length(), &ok);
   else
-    value = sign *
-            charactersToIntStrict(digits.characters16(), digits.length(), &ok);
+    value = charactersToIntStrict(digits.characters16(), digits.length(), &ok);
   return ok;
 }
 
 // http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-integers
 bool parseHTMLInteger(const String& input, int& value) {
   // Step 1
   // Step 2
   unsigned length = input.length();
   if (!length || input.is8Bit()) {
     const LChar* start = input.characters8();
@@ skipping 272 matching lines @@
     string = StringImpl::create8BitIfPossible(characters, size);
   else if (width == Force8Bit)
     string = String::make8BitFrom16BitSource(characters, size);
   else
     string = String(characters, size);
 
   return string;
 }
 
 }  // namespace blink