Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, do-not-use
Visibility:
Public.

Description

Have V8HiddenPropertyName static functions take an isolate in argument Have V8HiddenPropertyName static functions take an isolate in argument to avoid an implicit call to v8::Isolate::GetCurrent(). R=haraken BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/DateExtension.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8EventListenerList.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/v8/V8EventListenerList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8HiddenPropertyName.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8HiddenPropertyName.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/v8/V8LazyEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8NodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomEventCustom.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/custom/V8ErrorEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8PopStateEventCustom.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-20 14:04:02 UTC) #1
haraken
LGTM
7 years, 3 months ago (2013-09-20 14:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23637014/1
7 years, 3 months ago (2013-09-20 14:29:42 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 15:45:04 UTC) #4
Message was sent while issue was closed. 
Change committed as 158122

Powered by Google App Engine
This is Rietveld 408576698