Source/bindings/scripts/code_generator_v8.pm - Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 23637014: Have V8HiddenPropertyName static functions take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.pm

diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm

index f034d68969229e5fc92f6bc4f13ec9c4d47ef393..34bbf055c97ec6f1f7675c19758901836862465c 100644

--- a/Source/bindings/scripts/code_generator_v8.pm

+++ b/Source/bindings/scripts/code_generator_v8.pm

@@ -2721,7 +2721,7 @@ END

$implementation{nameSpaceInternal}->add(<<END);

options.get("${attrName}", ${attrName});

if (!${attrName}.IsEmpty())

- args.Holder()->SetHiddenValue(V8HiddenPropertyName::${attrName}(), ${attrName});

+ args.Holder()->SetHiddenValue(V8HiddenPropertyName::${attrName}(args.GetIsolate()), ${attrName});

END

}

« no previous file with comments | « no previous file | Source/bindings/v8/CustomElementConstructorBuilder.cpp » ('j') | no next file with comments »